Cache slots info & Removing "master_nodes" module variable #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* info in this table was not "per client" (like slot_cache) so it was containing a list of all master nodes of all cluster-clients ever instantiated * list was always growing (there were just appends to the table) * list of master nodes can be already obtained from the slots info already cached per client (this eliminates the need of an extra "nodes" query to redis)
…ker/timer context. In this case ngx.req.start_time() always returns 0 and max_connection_timeout always triggers a timeout without even attempting a connection
…_fix Fix for max_connection_timeout in worker/timer context
Previously, if a cached serv_list existed then these would be the only servers consulted. However, it is possible that the config serv_list has been updated which means any new addresses will not be considered. In most scenarios this is not a problem - the cluster knows the current active topology. But in the event that all nodes are suddenly lost (for example, the entire cluster is brought up on new addresses), the cache presumes itself to still be the source of truth. This commit appends our configured serv_list to the cached list (if present), and so if all cached servers fail, it will try from the configured list.
…v-list-when-fetching-slots Ensure configured serv_list is available when fetching slots
…t-refresh_slots fix commit_pipeline connect err not refresh_slots,when it has auth
shuxiao9058
force-pushed
the
cache_slots_info
branch
2 times, most recently
from
0227710 to
4729923
Compare
shuxiao9058
force-pushed
the
cache_slots_info
branch
from
4729923 to
e98490d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refer steve0511#86
also fix a potential bug caused with limit pool when tcp connect failed with
too many waiting connect operations.more details:
https://github.com/openresty/lua-nginx-module#tcpsockconnect