Support JSX spread property syntax #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
It looks like we stomped on this with some other PRs. @MarcoThePoro if you can fix the conflict I'll check and merge it and get it out there (finally). |
Collaborator
Author
|
This regex is becoming a monster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In jsx you can use the spread property syntax
{...object}in place of a property-value pair in a tag. less-than-slash was skipping any tags that had this.This adds support in the xml parser.
I'm getting concerned that maybe our regex is getting too complicated, but I don't know if it's actually causing any performance issues so it should be okay for now (Maybe JSX should get its own parser? Add a JSX option to the settings?). I changed the xmlparser test so that it checks that there is a (potential) whole tag before executing the more complex regex in the parse function. Not sure how much benefit this is.
@mrhanlon review?