Skip to content

fix: don't try to load non Chart directory with helm #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
qvalentin wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: don't try to load non Chart directory with helm #180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions internal/charts/chart.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,11 @@ func NewChart(rootURI uri.URI, valuesFilesConfig util.ValuesFilesConfig) *Chart
}

func loadHelmChart(rootURI uri.URI) (helmChart *chart.Chart) {
if !isChartDirectory(string(rootURI)) {
logger.Error(fmt.Sprintf("Not loading chart %s: not a chart directory (not Chart.yaml found)", rootURI.Filename()))
return getFallbackHelmChart()
}

chartLoader, err := loader.Loader(rootURI.Filename())
if err != nil {
logger.Error(fmt.Sprintf("Error loading chart %s: %s", rootURI.Filename(), err.Error()))
Expand Down
Loading