Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin data-default-class to >=0.2.0.0 and crypton-connection >=0.4.2 to avoid incompatibility issues #180

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

danwdart
Copy link
Contributor

Making sure that older versions of data-default-class aren't accepted, and make sure that we are using the crypton-connection version that works properly with this.

Technically this could be a cabal metadata update if you don't feel like a new PR.

Fixes #179.

Cheers!

@mrkkrp mrkkrp merged commit 272734e into mrkkrp:master Jan 15, 2025
4 checks passed
@danwdart danwdart deleted the pin-data-default-class branch January 15, 2025 13:16
@sternenseemann
Copy link

This forbids a previously working combination of data-default-class and crypton-connection. This specific combination being broken is quite unfortunate since it is the one prescribed by Stackage LTS. If you use Stackage LTS bounds and pull in Hackage revisions, this package breaks. I don't really understand why req has to solve this problem, shouldn't crypton-connection or data-default have the right bounds? req is downstream from these packages and shouldn't need to concern itself with the question whether they are compatible with each other.

Stackage LTS 23 has

  • req-3.13.4
  • crypton-connection-0.4.3
  • data-default-class-0.1.2.2
  • data-default-0.7.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation error due to data-default-class
3 participants