Fix hardware accelerated rotation. #1450
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix another bug where rotation was always set to 'clock' due to reading raw camera names instead of capitalizing them before accessing env variables. I tested this on a vaapi-enabled machine but looking at the following snippet from `frigate` ffmpeg code, I'm confident that this change also fixes things for `qsv`: https://github.com/blakeblackshear/frigate/blob/6f9d9cd5a853b7c7cb4058ada8dccdca8cbc3f5b/frigate/ffmpeg_presets.py#L67-L68
|
Since mrlt8 has been busy of late, I created a fork and merged the PR changes that have been pending for a while. Not trying to steal thunder, but I needed a stable source for updates. The repo does all the Docker Hub publishing and everything, so feel free to click the ADD ADD-ON REPOSITORY button in the repo or grab the new docker image from here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix another bug where rotation was always set to 'clock' due to reading raw camera names instead of capitalizing them before accessing env variables.
I tested this on a vaapi-enabled machine but looking at the following snippet from
frigateffmpeg code, I'm confident that this change also fixes things forqsv:https://github.com/blakeblackshear/frigate/blob/6f9d9cd5a853b7c7cb4058ada8dccdca8cbc3f5b/frigate/ffmpeg_presets.py#L67-L68
Closes #1276