feat: Native implementation for listeners (also now fires for AppClip/extension changes)#1067
Open
mrousavy wants to merge 1 commit into
Open
feat: Native implementation for listeners (also now fires for AppClip/extension changes)#1067mrousavy wants to merge 1 commit into
mrousavy wants to merge 1 commit into
Conversation
bcd8292 to
9aa33c4
Compare
9aa33c4 to
46e1adf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MMKVHandlerduring MMKV initialization and forward MMKV logs through Nitro's logger.addOnValueChangedListener(...)API.checkExternalContentChanged()to the MMKV HybridObject, with web/mock no-ops.checkExternalContentChanged()from the existing AppState listener setup.Verification
bun run specsbun run lint-cppbun lint-cibun run typecheckbun run test -- packages/react-native-mmkv/src/__tests__/hooks.test.tsx --runInBandHARNESS_WEB_URL=http://localhost:3000 bun --cwd example test:harness __tests__/MMKV.harness.ts --harnessRunner webcd example/android && ./gradlew :react-native-mmkv:externalNativeBuildRelease --no-daemonNote: earlier local
bun --cwd example build:android-releasepassed thereact-native-mmkvnative C++ build for all ABIs, then failed later in:app:createBundleReleaseJsAndAssetswhile starting the localnode_modules/react-native/sdks/hermesc/osx-bin/hermescbinary. The previous CI run passed Android build, iOS build, Android Harness, Web Harness, and all fast checks before this API simplification; CI is rerunning for the amended head.