Feature | Support onBytesWrittenVideo to receive bytes on JS while recording Video #3549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Owner
|
cool! |
mrousavy
approved these changes
Dec 11, 2025
Comment on lines
147
to
149
| DispatchQueue.main.async { | ||
| onBytesWritten(bytes) | ||
| } |
Owner
There was a problem hiding this comment.
Does this have to run on the main queue?
Contributor
Author
There was a problem hiding this comment.
It wasn't needed, I removed the execution on the main queue
|
@frodriguez-hu is attempting to deploy a commit to the mrousavy's Team Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR Adds the
onBytesWrittenVideocallback in order to receive the bytes of the video while it is being recorded.Changes
IOS
DispatchSourceTimeron Ios in order to read the file size from the FileSystem every 400 ms, that will be executed after the video has started and when finished the timer is cleaned.onBytesWrittenVideoEventasRCTDirectEventBlockin order to send events to JS inRCTViewManagerAndroid
onBytesWrittenVideoon thegetExportedCustomDirectEventTypeConstantsand all the logic to treat that as an Event and send data to JSVideoRecordEvent.Statusas it is available thereTSX/TS
NativeEventto just expose(bytes: number) => voidDocs
Tested on
Related issues