remove File.write to hard-coded xml_for_signing.xml. Fixes issue #39 #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldavidson
changed the title
obahareth
added a commit
to theamazingteam/zatca
that referenced
this pull request
Apr 30, 2025
Fix originally done by @aldavidson in mrsool#40
Contributor
|
I applied your fix in my fork and published it to rubygems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a File.write operation to a hard-coded filename
xml_for_signing.xmlthat means you can't run multiple zatca operations simultaneously in sidekiq, as they conflict and cause errors. See issue #39 for details.This PR fixes the problem by simply removing the
File.write- I can't see anywhere else that file is accessed, so presumably it's some debugging code that was inadvertently left in? (as per b4a4507#diff-ad3e2839a3df5a1ca12bed1822b34313e34095c0c03f010ad69f36e6330dd897R19)