Standardize search_timeout to seconds - #196
Closed
cryobry wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
I'll try to break out semantic changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes inconsistent search_timeout units by standardizing config to seconds and converting to milliseconds only at the SLSKD API call. Also updates docs/examples from 5000 to 5. This is a breaking config semantic change for users who previously supplied millisecond values.
Also addresses the following bug on line 476 that currently compares seconds to ms:
if (time.time() - start_time) > config.getint("Search Settings", "search_timeout", fallback=5000):