Skip to content

[Sync] Update project files from source repository (9a0bdd0)#193

Merged
mrz1836 merged 1 commit intomasterfrom
chore/sync-files-mrz-sdks-20260123-094508-9a0bdd0
Jan 23, 2026
Merged

[Sync] Update project files from source repository (9a0bdd0)#193
mrz1836 merged 1 commit intomasterfrom
chore/sync-files-mrz-sdks-20260123-094508-9a0bdd0

Conversation

@mrz1836
Copy link
Copy Markdown
Owner

@mrz1836 mrz1836 commented Jan 23, 2026

What Changed

  • Updated actions/checkout action from commit 8e8c483db84b4bee98b60c0593521ed34d9990e8 (v6.0.1) to de0fac2e4500dabe0009e67214ff5f5447ce83dd (v6.0.2) in fortress-completion-tests.yml and fortress-code-quality.yml
  • Modified the "Go vet (sequential)" step in fortress-code-quality.yml to continue on error by adding id: run-govet and continue-on-error: true
  • Added GOVET_EXIT_CODE=0 variable initialization in the go vet script
  • Updated error handling in the go vet step to write results to govet-output.log using tee command
  • Changed exit behavior to output GitHub Actions variables (govet-exit-code and govet-status) and exit with code 0 instead of 1 to allow summary generation to continue

Why It Was Necessary

  • The actions/checkout update addresses potential bug fixes or security improvements in the newer v6.0.2 release
  • Converting the go vet step to continue-on-error allows the workflow to capture failures and generate comprehensive summaries rather than stopping immediately
  • Outputting structured failure information enables better tracking and reporting of go vet issues through GitHub Actions outputs

Testing Performed

  • Verify that workflows using actions/checkout@v6.0.2 can successfully check out code
  • Test that go vet failures are properly captured in the govet-output.log file
  • Confirm that GitHub Actions outputs (govet-exit-code and govet-status) are correctly set when go vet encounters errors
  • Validate that the workflow continues to subsequent steps even when go vet fails

Impact / Risk

  • Low risk: The actions/checkout update is a minor version patch that should be backward compatible
  • Improved observability: The go vet changes allow better error tracking and don't cause workflow failures to block summary generation
  • Behavior change: Go vet failures will no longer immediately fail the job, which may require updates to dependent workflows or status checks

@mrz1836 mrz1836 self-assigned this Jan 23, 2026
@mrz1836 mrz1836 added automated-sync Automated sync PR, e.g. from a fork or external repo automerge Label to automatically merge pull requests that meet all required conditions chore Simple dependency updates or version bumps labels Jan 23, 2026
@github-actions github-actions Bot added update General updates size/XL Very large change (>500 lines) labels Jan 23, 2026
@mrz1836
Copy link
Copy Markdown
Owner Author

mrz1836 commented Jan 23, 2026

LGTM!

@mrz1836 mrz1836 merged commit 6359d22 into master Jan 23, 2026
46 checks passed
@github-actions github-actions Bot deleted the chore/sync-files-mrz-sdks-20260123-094508-9a0bdd0 branch January 23, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated-sync Automated sync PR, e.g. from a fork or external repo automerge Label to automatically merge pull requests that meet all required conditions chore Simple dependency updates or version bumps size/XL Very large change (>500 lines) update General updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant