Conversation
Owner
Author
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
.github/workflows/fortress-completion-finalize.ymlto use base64 encoding when processing workflow inputs and timing data, replacing the previousIFS='='approach<<EOF) for setting environment variables to safely handle multiline values likeenv-jsontr '-' '_') to ensure GitHub Actions expression compatibilityjq -r 'to_entries | .[] | @base64'followed by base64 decoding instead of direct string splittingWhy It Was Necessary
IFS='='was fragile and could not handle multiline values or complex JSON structures correctlyTesting Performed
env-json) are correctly parsed and stored in environment variablesImpact / Risk