Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
.github/actions/parse-env/action.ymlto move theENV_JSONinput from an inline shell variable to theenv:context for improved securitygithub-tokeninput parameter to.github/actions/setup-go-with-cache/action.ymlfor private module authentication (optional, defaults to empty string)setup-go-with-cachethat configures git authentication for private Go modules when bothgithub-tokenandGOPRIVATEare setgithub-token: ${{ secrets.GITHUB_TOKEN }}to thesetup-go-with-cacheaction00-core.env,10-mage-x.env, and10-pre-commit.env(specific changes to variables likeMAGE_X_VERSIONfromv1.12.1tov1.12.2)permissions:blocks in various workflow files to explicitly setcontents: readWhy It Was Necessary
ENV_JSONto the environment context prevents potential injection attacks by avoiding direct interpolation of user input into shell scriptsTesting Performed
env:context approachGOPRIVATEis set and a token is providedGONOSUMDBis automatically set to matchGOPRIVATEwhen not explicitly definedImpact / Risk
GOPRIVATEand a token