This repository was archived by the owner on Jan 3, 2020. It is now read-only.
Add support for reading and subscribing to input pullup #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for reading and subscribing to input pullup
|
+1 for this, spent an entire night trying to figure out why this wasn't working. Pretty sloppy to not give any error but just completely ignore the pinMode imho. |
|
Thanks for the commit! I'm starting to get back into this project. I'll give it a review and pull it as soon as possible. |
|
This is a good stop gap, but it is not setting the internal pullup resistor on the Arduino. The message defined here, by the Firmata team... #define PIN_MODE_PULLUP 0x0B // enable internal pull-up resistor for pin...needs to be added to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was setting up a demo using buttons and ran into problems using the internal pullup resisters on my Arduino UNO and YUN. After looking at the source code, it looks like the PULLUP PinMode is just ignored. This PR adds in support for subscribing to the port and reading the state out of the cache.