Feature/custom pytest workflows #59
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
…kflows_develop Trigger github actions when PR is made against develop
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
This reverts commit cd3180c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@anoronh4 following up on the issue of the licensed sentieon modules (PR #30), I believe I found a way we can use our own custom master pytest-workflow without causing merge conflicts.
It turns out you can disable certain workflows for a repository: https://docs.github.com/en/actions/using-workflows/disabling-and-enabling-a-workflow. So I disabled the pytest-workflow action https://github.com/mskcc-omics-workflows/modules/actions/workflows/pytest-workflow.yml which will prevent pytest from running on master. And with this PR, I'm adding in
pytest-workflow-master.yml, which takes a page from yourpytest-workflow-develop.ymland excludes the sentieon modules from running. This should hopefully give us relatively clean pytest-ing for our master branch free from the sentieon modules and redundant tests on master.I still have some concerns about other modules and their tests, but maybe later we can discuss which pytests we'd like to curate for this repository?
Let me know your thoughts!