Skip to content

Conversation

huyu335
Copy link
Collaborator

@huyu335 huyu335 commented Jun 24, 2023

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

buehlere and others added 30 commits May 9, 2023 15:48
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
This reverts commit 13d45de, reversing
changes made to ab7ba98.
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
@huyu335 huyu335 assigned anoronh4 and buehlere and unassigned anoronh4 and buehlere Jun 24, 2023
@huyu335 huyu335 requested review from anoronh4 and buehlere June 24, 2023 02:27
@huyu335
Copy link
Collaborator Author

huyu335 commented Jun 24, 2023

I'm reusing https://github.com/mskcc-omics-workflows/test-datasets as the source of the test data. This repo is now public so no token is needed.

Copy link
Collaborator

@buehlere buehlere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left one small comment on the config file. Let me know your thoughts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants