Support addInitScript in no-unsafe-references
#369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mskelton
changed the title
addInitScript in no-unsafe-references
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends the no-unsafe-references ESLint rule to also support page.addInitScript(), updating code logic, tests, and documentation accordingly, and adjusts test scripts in package.json.
- Added
addInitScripthandling in the rule’s checks, fixes, and error messages - Expanded test suite to cover
page.addInitScriptscenarios - Updated documentation and test scripts (
package.json)
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/rules/no-unsafe-references.ts | Include addInitScript in isPageMethod checks, message data, and docs |
| src/rules/no-unsafe-references.test.ts | Added numerous test cases and outputs for addInitScript |
| package.json | Modified test and test:watch scripts to include --run |
| docs/rules/no-unsafe-references.md | Updated examples and description to mention page.addInitScript |
Comments suppressed due to low confidence (1)
package.json:39
- The
--runflag causes Vitest to exit immediately rather than watching. Remove--runto enable continuous watch mode.
"test:watch": "vitest --reporter=dot --run",
Co-authored-by: Copilot <[email protected]>
|
🎉 This PR is included in version 2.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
carlbray
pushed a commit
to carlbray/eslint-plugin-playwright
that referenced
this pull request
Aug 17, 2025
* no-unsafe-references for addInitScript * Update src/rules/no-unsafe-references.ts Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #365