fix: no-conditional-in-test does not trigger for conditionals in test metadata (fixes #363) #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the no-conditional-in-test ESLint rule so that it only flags conditionals inside the actual test function body (not in the metadata object) and adds a new test case to verify this behavior.
- Restrict reporting to ternaries within the test callback function
- Early-return when the last argument isn’t a function
- Add a valid test confirming metadata conditionals are allowed
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/rules/no-conditional-in-test.ts | Wraps the existing report call in a check that the node is inside the test function body only |
| src/rules/no-conditional-in-test.test.ts | Adds a valid test case ensuring conditionals in the metadata object do not trigger the rule |
| CLAUDE.md | Introduces high-level project guidelines document |
| .cursor/rules/eslint-plugin-playwright.mdc | Expands detailed internal ESLint-plugin development guidelines |
|
🎉 This PR is included in version 2.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
carlbray
pushed a commit
to carlbray/eslint-plugin-playwright
that referenced
this pull request
Aug 17, 2025
… metadata (fixes mskelton#363) (mskelton#372) * fix: no-conditional-in-test rule triggers for test metadata conditionals * Agents win * Sync * Sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #363.