Adding closeOnEscape and tabThrough properties#193
Open
hpaves wants to merge 9 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Author
|
Docs edit broke the deployment? I can't inspect on Vercel, gives me a 404. |
No access to logs, but best guess, and we'll see on GH checks
hpaves
changed the title
Owner
|
You don't need to care about failed deployment for v5 branch... Will go through it in next few days |
less parameters needed to change watchface color and retain the minimalist look
Owner
|
Why are you combining multiple changes in single PR? I will probably rework it myself. In general both (esc and tab handling) is good idea, but I would change the API of it slightly. But I am really busy right now, so it will take some time |
Author
|
Apologies, I got a little carried away. Clearly I should have branched. I'll see if I can fix it after the fact. |
Owner
|
Don't bother. I will do it myself. I would need to update your PR anyway. But it's good you wanted to contribute. As I said, it's useful 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added escClosesPicker property that allows dismissal of the picker with Escape while keeping the input value.