Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ export default defineConfig(
'eslint.config.js',
'svelte.config.js',
'**/vite.*.ts',
'./test/utils/ContextWrapper.svelte',
]),
{
languageOptions: {
Expand Down
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"rollup-plugin-copy": "~3.5.0",
"sass": "~1.93.2",
"smui-theme": "~8.0.3",
"svelte": "~5.39.11",
"svelte": "~5.40.1",
"svelte-check": "~4.3.3",
"typescript": "~5.9.3",
"typescript-eslint": "~8.45.0",
Expand Down
8 changes: 1 addition & 7 deletions src/options/Options.svelte.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,8 @@ import { beforeEach, describe, expect, it, vi } from 'vitest';

import Options from '@Treetop/options/Options.svelte';

import ContextWrapper from '../../test/utils/ContextWrapper.svelte';

const setup = () => {
render(ContextWrapper, {
Component: Options,
Props: {},
Context: {},
});
render(Options);
};

describe('Options', () => {
Expand Down
18 changes: 10 additions & 8 deletions src/treetop/Bookmark.svelte
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
<script lang="ts">
import { getContext } from 'svelte';
import type { SvelteDate } from 'svelte/reactivity';
import lodashTruncate from 'lodash-es/truncate';

import type * as Treetop from './types';
import {
getClock,
getLastVisitTimeMap,
getTooltips,
getTruncate,
} from './context';
import { truncateMiddle } from './utils';

interface Props {
Expand All @@ -14,11 +17,10 @@

let { nodeId, title, url }: Props = $props();

const lastVisitTimeMap: Treetop.LastVisitTimeMap =
getContext('lastVisitTimeMap');
const truncate = getContext<() => boolean>('truncate');
const tooltips = getContext<() => boolean>('tooltips');
const clock = getContext<SvelteDate>('clock');
const lastVisitTimeMap = getLastVisitTimeMap();
const truncate = getTruncate();
const tooltips = getTooltips();
const clock = getClock();

const lastVisitTime = $derived(lastVisitTimeMap.get(nodeId)!);

Expand Down
20 changes: 9 additions & 11 deletions src/treetop/Bookmark.svelte.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,9 @@ import { render, screen } from '@testing-library/svelte';
import escapeRegExp from 'lodash-es/escapeRegExp';
import { beforeEach, describe, expect, it } from 'vitest';

import Bookmark from '@Treetop/treetop/Bookmark.svelte';
import type * as Treetop from '@Treetop/treetop/types';

import ContextWrapper from '../../test/utils/ContextWrapper.svelte';
import BookmarkWrapper from '../../test/utils/BookmarkWrapper.svelte';

let lastVisitTimeMap: Treetop.LastVisitTimeMap;
let currentTruncate: boolean;
Expand All @@ -29,15 +28,14 @@ const MILLISECONDS_PER_HOUR =
60; // minutes per hour

const setup = () => {
render(ContextWrapper, {
Component: Bookmark,
Props: { nodeId, title, url },
Context: {
lastVisitTimeMap,
truncate,
tooltips,
clock,
},
render(BookmarkWrapper, {
lastVisitTimeMap,
truncate,
tooltips,
clock,
nodeId,
title,
url,
});
};

Expand Down
17 changes: 10 additions & 7 deletions src/treetop/Folder.svelte
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
<script lang="ts">
import { getContext } from 'svelte';

import Bookmark from './Bookmark.svelte';
import {
getBuiltInFolderInfo,
getFilterActive,
getFilterSet,
getFolderNodeMap,
} from './context';
import Folder from './Folder.svelte';
import * as Treetop from './types';

Expand All @@ -12,11 +16,10 @@

let { nodeId, root = false }: Props = $props();

const builtInFolderInfo: Treetop.BuiltInFolderInfo =
getContext('builtInFolderInfo');
const folderNodeMap = getContext<Treetop.FolderNodeMap>('folderNodeMap');
const filterActive = getContext<() => boolean>('filterActive');
const filterSet = getContext<Treetop.FilterSet>('filterSet');
const builtInFolderInfo = getBuiltInFolderInfo();
const folderNodeMap = getFolderNodeMap();
const filterActive = getFilterActive();
const filterSet = getFilterSet();

const node = $derived(folderNodeMap.get(nodeId)!);

Expand Down
30 changes: 12 additions & 18 deletions src/treetop/Folder.svelte.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,13 @@ import { render, screen } from '@testing-library/svelte';
import type { MockInstance } from 'vitest';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import Folder from '@Treetop/treetop/Folder.svelte';
import type * as Treetop from '@Treetop/treetop/types';

import ContextWrapper from '../../test/utils/ContextWrapper.svelte';
import {
createBookmarkNode,
createFolderNode,
} from '../../test/utils/factories';
import FolderWrapper from '../../test/utils/FolderWrapper.svelte';

// Folder component requirements
let builtInFolderInfo: Treetop.BuiltInFolderInfo;
Expand All @@ -31,22 +30,17 @@ let clock: SvelteDate;
let rootNode: Treetop.FolderNode;

const setup = () => {
render(ContextWrapper, {
Component: Folder,
Props: {
nodeId,
root: true,
},
Context: {
builtInFolderInfo,
folderNodeMap,
lastVisitTimeMap,
filterActive,
filterSet,
truncate,
tooltips,
clock,
},
render(FolderWrapper, {
builtInFolderInfo,
folderNodeMap,
lastVisitTimeMap,
filterActive,
filterSet,
truncate,
tooltips,
clock,
nodeId,
root: true,
});
};

Expand Down
28 changes: 19 additions & 9 deletions src/treetop/Treetop.svelte
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<script lang="ts">
import { onDestroy, onMount, setContext } from 'svelte';
import { onDestroy, onMount } from 'svelte';
import { SvelteMap, SvelteSet } from 'svelte/reactivity';
import { fade } from 'svelte/transition';
import LinearProgress from '@smui/linear-progress';
Expand All @@ -14,6 +14,16 @@
import { BookmarksManager } from './BookmarksManager';
import { createClock } from './clock.svelte';
import ConfirmationDialog from './ConfirmationDialog.svelte';
import {
setBuiltInFolderInfo,
setClock,
setFilterActive,
setFilterSet,
setFolderNodeMap,
setLastVisitTimeMap,
setTooltips,
setTruncate,
} from './context';
import FilterInput from './FilterInput.svelte';
import { FilterManager } from './FilterManager';
import Folder from './Folder.svelte';
Expand Down Expand Up @@ -47,8 +57,8 @@
);

// Make select preferences available to other components
setContext('truncate', truncate);
setContext('tooltips', tooltips);
setTruncate(truncate);
setTooltips(tooltips);

//
// Create bookmarks data and manager
Expand Down Expand Up @@ -90,12 +100,12 @@
const clock = createClock();

// Make bookmark data available to other components
setContext('builtInFolderInfo', builtInFolderInfo);
setContext('folderNodeMap', folderNodeMap);
setContext('lastVisitTimeMap', lastVisitTimeMap);
setContext('filterActive', () => filterActive);
setContext('filterSet', filterSet);
setContext('clock', clock);
setBuiltInFolderInfo(builtInFolderInfo);
setFolderNodeMap(folderNodeMap);
setLastVisitTimeMap(lastVisitTimeMap);
setFilterActive(() => filterActive);
setFilterSet(filterSet);
setClock(clock);

//
// Error notification
Expand Down
9 changes: 2 additions & 7 deletions src/treetop/Treetop.svelte.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,11 @@ import { describe, expect, it, vi } from 'vitest';

import Treetop from '@Treetop/treetop/Treetop.svelte';

import ContextWrapper from '../../test/utils/ContextWrapper.svelte';
import { createBrowserBookmarksTree } from '../../test/utils/factories';

const setup = () => {
render(ContextWrapper, {
Component: Treetop,
Props: {
rootBookmarkId: null,
},
Context: {},
render(Treetop, {
rootBookmarkId: null,
});
};

Expand Down
26 changes: 26 additions & 0 deletions src/treetop/context.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
import { createContext } from 'svelte';
import type { SvelteDate } from 'svelte/reactivity';

import * as Treetop from './types';

export const [getBuiltInFolderInfo, setBuiltInFolderInfo] =
createContext<Treetop.BuiltInFolderInfo>();

export const [getClock, setClock] = createContext<SvelteDate>();

export const [getFilterActive, setFilterActive] =
createContext<() => boolean>();

export const [getFilterSet, setFilterSet] = createContext<Treetop.FilterSet>();

export const [getFolderNodeMap, setFolderNodeMap] =
createContext<Treetop.FolderNodeMap>();

export const [getLastVisitTimeMap, setLastVisitTimeMap] =
createContext<Treetop.LastVisitTimeMap>();

export const [getTooltips, setTooltips] =
createContext<() => Treetop.PreferenceValue>();

export const [getTruncate, setTruncate] =
createContext<() => Treetop.PreferenceValue>();
33 changes: 33 additions & 0 deletions test/utils/BookmarkWrapper.svelte
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
<script lang="ts">
// Wrapper component to test Bookmark component with context.
import type { ComponentProps } from 'svelte';
import type { SvelteDate } from 'svelte/reactivity';

import Bookmark from '@Treetop/treetop/Bookmark.svelte';
import {
setClock,
setLastVisitTimeMap,
setTooltips,
setTruncate,
} from '@Treetop/treetop/context';
import * as Treetop from '@Treetop/treetop/types';

type BookmarkProps = ComponentProps<typeof Bookmark>;

type Props = BookmarkProps & {
lastVisitTimeMap: Treetop.LastVisitTimeMap;
truncate: () => boolean;
tooltips: () => boolean;
clock: SvelteDate;
};

const { lastVisitTimeMap, truncate, tooltips, clock, ...props }: Props =
$props();

setLastVisitTimeMap(lastVisitTimeMap);
setTruncate(truncate);
setTooltips(tooltips);
setClock(clock);
</script>

<Bookmark {...props} />
23 changes: 0 additions & 23 deletions test/utils/ContextWrapper.svelte

This file was deleted.

Loading