Skip to content

feat (diagnosticsettings): [general] remove alllogs category in favor of specific ones #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 12, 2025
Merged

feat (diagnosticsettings): [general] remove alllogs category in favor of specific ones #440

merged 5 commits into from
Jun 12, 2025
+425 −23

Conversation

ferantivero
Copy link
Contributor

@ferantivero ferantivero commented Jun 6, 2025 •
edited
Loading

WHY

we wanted to change diagnostic setting allLogs category group to specific categories that can be picked out based on the user's preference

WHAT

  • change all diagnostic from category group to category specific

Test

image image

@ferantivero ferantivero marked this pull request as ready for review June 12, 2025 00:21
ckittel
ckittel approved these changes Jun 12, 2025
View reviewed changes
Copy link
Member

@ckittel ckittel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If you have merge access issues, LMK.

@ckittel ckittel merged commit 4fab783 into mspnp:main Jun 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckittel ckittel ckittel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ferantivero @ckittel