Separate additional fields by ":" instead of ": " #707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimplyDanny
requested changes
Jan 2, 2026
Collaborator
SimplyDanny
left a comment
SimplyDanny
left a comment
There was a problem hiding this comment.
Your reasoning makes sense to me.
Looks like this can be changed without breaking existing password files. However, you need to make sure that splitting only happens on the first colon (subsequent ones might be parts of values).
passKit/Parser/Parser.swift
Outdated
Comment on lines
74
to
89
| var key: String? | ||
| var value = "" | ||
| if items.count == 1 || (items[0].isEmpty && items[1].isEmpty) { | ||
| // No ': ' found, or empty on both sides of ': '. | ||
| value = line | ||
| // "otpauth" special case | ||
| if value.hasPrefix(Constants.OTPAUTH_URL_START) { | ||
| key = Constants.OTPAUTH | ||
| } | ||
| } else { | ||
| if !items[0].isEmpty { | ||
| key = items[0] | ||
| } | ||
| value = items[1] | ||
| } | ||
| return (key, value) |
Collaborator
There was a problem hiding this comment.
This parts needs adaptions as well. otpauth is now already covered by the initial split. We'd also need test cases.
MuAlphaOmegaEpsilon
force-pushed
the
tweak-additional-fields-separator
branch
2 times, most recently
from
fff40a4 to
a610a4f
Compare
MuAlphaOmegaEpsilon
force-pushed
the
tweak-additional-fields-separator
branch
from
a610a4f to
849f4f5
Compare
Author
|
Pushed an update that only splits on the first occurrence of |
Collaborator
|
Tests are failing. Please check them out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a pass file, additional key-value pairs are supposed to be stored separated by a single semicolon
:.This is to allow simple command line interoperability, like in the following case:
The OTP authorization key is already working as intended, as it can be seen from the screenshot below. All additional fields should be recognized with the simpler
:separator, instead of the current:one containing a whitespace.