5535 Exclude requisition made from web entries in mSupply #5536

raviSussol · 2025-04-07T12:18:20Z

Fixes #5535

Change summary

Removed wp and wf statuses from requisition schema and its related method to stop processing incoming requisitions made from web entries in the mSupply.
Fixed data linkage between Transaction & 'Requisiton` objects they have been broken from #5406 don't create blank supplier requisitions #5407

Testing

Steps to reproduce or otherwise test the changes of this PR:

Tests

Test 1
Should not display blank or having serial number 0 requisition
Also check the customer requisition - should not have any blank or having serial number 0 requisition
Please do regression tests related requisitions (both customer and supplier)
- Setup 2 mobile apps and 1 oms site (i.e 1 oms central server with 1 oms remote) and 1 mSupply central server and 1 mSupply remote desktop site
- Try creating some invoices (i.e from internal order or supplier requisition or request requisition -> response requisition or customer requisition -> customer invoice or outbound shipment (then via stock transfer) -> supplier invoice or inbound shipment
- Do thorough tests on these workflow among OG mobile, oms site, msupply sites and see if there anything gets broken - should be working flawlessly
Test 2
All blank requisitions will be gone in the mobile and requisitions having wp status will also be gone from the mSupply
Test 3
In the Requisition object goto the linkedTransaction field where you can see linked transaction records in it
Similarly, in the Transaction object goto the linkedRequisition field where you can see linked requisition records in there

…their lines

no migration code need for cleaning blank requisition since we need to re-initialize mobile app from the sync server anyway so all of those blank requisitions will be handled there

AnushaUp · 2025-04-09T11:00:38Z

…s deletion action for foreign objects

anildahalsussol · 2025-04-18T05:45:46Z

src/dataMigration.js

Makes sense so updating transaction so we dont create any blank requisiton in future and also updating requisition and deleting that too...

anildahalsussol · 2025-04-18T05:47:54Z

src/sync/incomingSyncUtils.js

+      if (record.store_ID !== settings.get(THIS_STORE_ID)) break; // Not for this store
+
+      const status = REQUISITION_STATUSES.translate(record.status, EXTERNAL_TO_INTERNAL);
+      if (!status) break; // Must be a requisition status, either 'suggested' or 'finalised'


Nice so we will not proceed if desired status is not received.

anildahalsussol · 2025-04-18T05:48:56Z

src/sync/syncTranslators.js

@@ -142,12 +142,11 @@ export const NAME_TYPES = new SyncTranslator({
 */
 class RequisitionStatusTranslator extends SyncTranslator {
  translate(status, direction) {
-    if (['cn', 'wf'].includes(status)) return 'finalised';
+    if (status === 'cn') return 'finalised';


anildahalsussol

Over all looks good to me.

anildahalsussol · 2025-04-18T05:54:54Z

src/dataMigration.js

@@ -286,6 +286,45 @@ const dataMigrations = [
      clearNumberSequences(database);
    },
  },
+  {
+    version: '8.7.0',


@raviSussol : I was thinking still WP is mysterious but we are known with another case of creating blank requisition. Is there a place where it can check blank so we dont need to make everytime migrate code?

anildahalsussol · 2025-04-18T08:13:28Z

As seen while testing wp status requisition seems valid requisition with status fn and also can see linked response requisition and related requisition lines. So not sure should we deleted or if its valid then improve it looking at the response requisition?

ujwalSussol · 2025-04-23T13:00:52Z

update : was able to set up the Master mobile...
Now tomorrow will aim to build mobile via this PR.

I am using Node V14.21.3 ( think this is the best that we can do for now )

…tries

ujwalSussol · 2025-04-24T11:06:11Z

@raviSussol : The testing I have done, looks positive...

Now I think what we need is a big Group test from @santoshkhanal12 and @AnushaUp and perhaps a few one of of us.

ujwalSussol

approved : But we do need to do a group test to make sure that daily activities are not messed up.

raviSussol · 2025-04-25T04:35:17Z

approved : But we do need to do a group test to make sure that daily activities are not messed up.

Yes that would be great to have other functional or regression tests before releasing the new version.

5535 Exclude requisition made from web entries in mSupply

cd1613a

raviSussol linked an issue Apr 7, 2025 that may be closed by this pull request

Invalid Requisition appears to be created due to Finalised Supplier Invoice #5535

Open

raviSussol requested a review from Copilot April 7, 2025 12:46

This comment was marked as resolved.

Sign in to view

raviSussol added 2 commits April 7, 2025 23:28

5535 add migration code to remove all blank request requisitions and …

e449cd3

…their lines

5535 update clean shell script to clean android build files

857a7a4

raviSussol marked this pull request as draft April 8, 2025 03:23

raviSussol added 2 commits April 9, 2025 11:09

5535 handle linkage between transaction and requisition objects

2b86ea8

5535 remove migration code

fa90f60

no migration code need for cleaning blank requisition since we need to re-initialize mobile app from the sync server anyway so all of those blank requisitions will be handled there

raviSussol marked this pull request as ready for review April 9, 2025 06:28

AnushaUp added the tester: Anusha label Apr 9, 2025

raviSussol added 5 commits April 10, 2025 18:15

5535 revert transaction linked to requisition code

1a53892

5535 add data migration code

5e5303f

5535 update schema version

65586bd

5535 fix data migration code error

68bb0b7

5535 wrap data migration code in try catch

6b42e6d

raviSussol added the Bug: production Bug was found or believed to be in a live release label Apr 14, 2025

5535 remove requisitionItems deletion as requisition deletion cascade…

676ce31

…s deletion action for foreign objects

anildahalsussol reviewed Apr 18, 2025

View reviewed changes

anildahalsussol approved these changes Apr 18, 2025

View reviewed changes

anildahalsussol reviewed Apr 18, 2025

View reviewed changes

raviSussol added 2 commits April 23, 2025 21:20

Merge branch 'develop' into 5535-exclude-requisition-made-from-web-en…

a4a0253

…tries

5535 upgrade version

5a49276

ujwalSussol approved these changes Apr 24, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

5535 Exclude requisition made from web entries in mSupply #5536

5535 Exclude requisition made from web entries in mSupply #5536

raviSussol commented Apr 7, 2025 •

edited by ujwalSussol

Loading

This comment was marked as resolved.

AnushaUp commented Apr 9, 2025 •

edited

Loading

anildahalsussol Apr 18, 2025

anildahalsussol Apr 18, 2025

anildahalsussol Apr 18, 2025

anildahalsussol left a comment

anildahalsussol Apr 18, 2025

anildahalsussol commented Apr 18, 2025

ujwalSussol commented Apr 23, 2025 •

edited

Loading

ujwalSussol commented Apr 24, 2025

ujwalSussol left a comment

raviSussol commented Apr 25, 2025

5535 Exclude requisition made from web entries in mSupply #5536

Are you sure you want to change the base?

5535 Exclude requisition made from web entries in mSupply #5536

Conversation

raviSussol commented Apr 7, 2025 • edited by ujwalSussol Loading

Change summary

Testing

Tests

This comment was marked as resolved.

AnushaUp commented Apr 9, 2025 • edited Loading

Testing

Tests

anildahalsussol Apr 18, 2025

Choose a reason for hiding this comment

anildahalsussol Apr 18, 2025

Choose a reason for hiding this comment

anildahalsussol Apr 18, 2025

Choose a reason for hiding this comment

anildahalsussol left a comment

Choose a reason for hiding this comment

anildahalsussol Apr 18, 2025

Choose a reason for hiding this comment

anildahalsussol commented Apr 18, 2025

ujwalSussol commented Apr 23, 2025 • edited Loading

ujwalSussol commented Apr 24, 2025

ujwalSussol left a comment

Choose a reason for hiding this comment

raviSussol commented Apr 25, 2025

raviSussol commented Apr 7, 2025 •

edited by ujwalSussol

Loading

AnushaUp commented Apr 9, 2025 •

edited

Loading

ujwalSussol commented Apr 23, 2025 •

edited

Loading