Skip to content

Simplify prescription line edit #6817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from

Conversation

lache-melvin
Copy link
Contributor

πŸ‘©πŸ»β€πŸ’» What does this PR do?

Sadly did not get time to finish this, but have implemented separate to existing prescription line edit so can compare. A few pieces still missing but hopefully the thinking is helpful

Some experiments:

  • Splitting into more components - each should have one job
    • Hopefully easier to follow based on what you see in UI, though I think this could improve further
  • Helpers into own, testable files where possible
  • Save on each item, one less layer of data management
  • State management only where needed, rather than "see item has changed, clear this"
  • Stripping out some logic for
  • Returning items from backend on invoice node - helpful for line edit list, but also think we should use this for things like item directions, prescribed quantity...

πŸ’Œ Any notes for the reviewer?

πŸ§ͺ Testing

  • (e.g.) Central Sync server with 1 Legacy Desktop remote site and 1 OMS remote site running this PR
  • (e.g.) This sample datafile: google drive link
  • (e.g.) Open a requisition with some lines
  • (e.g.) Make a couple invoices supplying some amount of those lines
  • (e.g.) Review that "issued" column is the sum of the amount already issued in invoices for this requisition

πŸ“ƒ Documentation

  • Part of an epic: documentation will be completed for the feature as a whole
  • No documentation required: no user facing changes or a bug fix which isn't a change in behaviour
  • These areas should be updated or checked:
    1.
    2.

πŸ“ƒ Reviewer Checklist

The PR Reviewer(s) should fill out this section before approving the PR

Breaking Changes

  • No Breaking Changes in the Graphql API
  • Technically some Breaking Changes but not expected to impact any integrations

Issue Review

  • All requirements in original issue have been covered
  • A follow up issue(s) have been created to cover additional requirements

Tests Pass

  • Postgres
  • SQLite
  • Frontend

@lache-melvin lache-melvin deleted the simple-prescription-line-edit branch May 1, 2025 21:47
@lache-melvin
Copy link
Contributor Author

Closing as too far behind develop, best to apply from scratch when we make time for this work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant