Skip to content

Upgrade AutocompleteWithPagination styling #7194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 28, 2025
Merged

Upgrade AutocompleteWithPagination styling #7194

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
db2bbe9
Upgrade autocomplete styling
zachariah-at-msupply Apr 3, 2025
8b54204
Merge branch 'develop' into 5336-fix-store-selector-dropdown-width
zachariah-at-msupply Apr 3, 2025
daac4bb
Upgrade autocomplete styling
zachariah-at-msupply Apr 3, 2025
a578f39
Merge branch 'v2.7.0-RC' into 5336-fix-store-selector-dropdown-width
zachariah-at-msupply Apr 7, 2025
b44e1bd
Revert to using ellipses
zachariah-at-msupply Apr 3, 2025
c85c0a8
Merge branch 'v2.7.0-RC' into 5336-fix-store-selector-dropdown-width
zachariah-at-msupply Apr 14, 2025
e308115
Merge branch 'v2.7.0-RC' into 5336-fix-store-selector-dropdown-width
CarlosNZ Apr 15, 2025
91cf2eb
Merge branch 'v2.7.0-RC' into 5336-fix-store-selector-dropdown-width
zachariah-at-msupply Apr 16, 2025
c192c33
Use ellipses for AutocompleteWithPagination options
zachariah-at-msupply Apr 16, 2025
ddbbfcd
Revert "Upgrade autocomplete styling"
zachariah-at-msupply Apr 16, 2025
00f0b9f
Remove comments
zachariah-at-msupply Apr 16, 2025
eb216db
Merge branch 'v2.7.0-RC' into 5336-fix-store-selector-dropdown-width
zachariah-at-msupply Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion client/packages/common/src/ui/components/inputs/Autocomplete/AutocompleteList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,9 +152,15 @@ export const AutocompleteList = <T,>({
},
},
listbox: {
style: {
sx: {
minHeight: height ? `${height}` : 'auto',
maxHeight: height ? `${height}` : 'auto',
'& .MuiTypography-root': {
maxWidth: 497,
whiteSpace: 'nowrap',
overflow: 'hidden',
textOverflow: 'ellipsis',
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually very hesitant to approve something like this because Autocomplete is used in so many places, and I don't fully understand the ramifications of these changes.

Particularly unsure about the hard coded values. I wonder would this affect other places Autocomplete is used?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would affect other places for Autocomplete. Though shouldn't be harmful bur rather helpful.

},
},
}}
Expand Down
Loading