Search for the pref you want!

[jmbrunskill]

Fixes #9762

👩🏻‍💻 What does this PR do?

Allows you to search for prefs!

💌 Any notes for the reviewer?

AI Generated code, but looks fine? UI Could probably be improved and more consistent but seems like a helpful improvement for no effort?

Haven't added to Global prefs but looks like an easy change...

🧪 Testing

• (e.g.) Central Sync server with 1 Legacy Desktop remote site and 1 OMS remote site running this PR
• (e.g.) This sample datafile: google drive link
• (e.g.) Open a requisition with some lines
• (e.g.) Make a couple invoices supplying some amount of those lines
• (e.g.) Review that "issued" column is the sum of the amount already issued in invoices for this requisition

📃 Documentation

• Part of an epic: documentation will be completed for the feature as a whole
• No documentation required: no user facing changes or a bug fix which isn't a change in behaviour
• These areas should be updated or checked:
  1.
  2.

📃 Reviewer Checklist

The PR Reviewer(s) should fill out this section before approving the PR

Breaking Changes

• No Breaking Changes in the Graphql API
• Technically some Breaking Changes but not expected to impact any integrations

Issue Review

• All requirements in original issue have been covered
• A follow up issue(s) have been created to cover additional requirements

Tests Pass

• Postgres
• SQLite
• Frontend

[mark-prins]

😍 great idea! thanks @jmbrunskill that's super helpful!!

can we please pause merging until I can get a design opinion - I don't like that the search looks like a preference itself! I think it should stand out more; would like a second opinion.

and the issue linked isn't specifically for this; we shouldn't close 9696 when this PR is merged, and there's potential to be misled. can you create an issue for the pref search and link to this PR please

[jmbrunskill]

😍 great idea! thanks @jmbrunskill that's super helpful!!

can we please pause merging until I can get a design opinion - I don't like that the search looks like a preference itself! I think it should stand out more; would like a second opinion.

and the issue linked isn't specifically for this; we shouldn't close 9696 when this PR is merged, and there's potential to be misled. can you create an issue for the pref search and link to this PR please

Yeah I think the UI could be improved but glad you like the concept. Will raise an issue. Needs to be done for the Global Prefs too.

I think we should also consider this ASAP too...
#7802

There two prefs are in dire need to explantion for example

[mark-prins]

some designs 😄

please ignore the slightly different look of the OK button and toggles - the wrong MUI component has been used in figma:

points to note

• full width filter bar (am leaning into the filter rather than search, bc the action will filter the list of prefs shown)
• a 'start icon' of the filter
• and a clear option on the input
• left align the text in the input

and to consider:

• we didn't include the word 'filter' as a header or placeholder. I thought it would be evident enough
• Ideally the top section of this modal would have a light grey background, as per the requisition detail modal, to prevent the tab control floating in the middle of a whitespace wonderland. could we do that with this PR? please....??

[mark-prins]

thanks @jmbrunskill
have updated to look like this: