fix(MockHttpSocket): support keepalive (reused) sockets #560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michael Solomon <[email protected]>
…541) Co-authored-by: Michael Solomon <[email protected]>
Co-authored-by: Artem Zakharchenko <[email protected]>
kettanaito
changed the base branch from
main
to
feat/yet-another-socket-interceptor
kettanaito
commented
Apr 18, 2024
| private customAgent?: http.RequestOptions['agent'] | ||
| private onRequest: MockHttpSocketRequestCallback | ||
| private onResponse: MockHttpSocketResponseCallback | ||
| export function createHttpAgent(options: MockAgentOptions): http.Agent { |
Member
Author
There was a problem hiding this comment.
Mandatory change. Otherwise, we aren't respecting the options.customAgent enough (ignoring its keepalive, max sockets, etc.).
kettanaito
commented
Apr 18, 2024
| * @see https://github.com/nodejs/node/blob/29ec7e9331c4944006ffe28e126cc31cc3de271b/lib/_http_client.js#L713 | ||
| */ | ||
| this.responseStream?.push(null) | ||
| this.emit('end') |
Member
Author
There was a problem hiding this comment.
I have no idea what to do on the socket so it:
- Signals the ClientRequest that the response has ended.
- Stays alive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.