Add regression test for got compression issue - Do not merge#2665
Open
AndyMJones wants to merge 1 commit intomswjs:mainfrom
Open
Add regression test for got compression issue - Do not merge#2665AndyMJones wants to merge 1 commit intomswjs:mainfrom
AndyMJones wants to merge 1 commit intomswjs:mainfrom
Conversation
Contributor
Author
|
On reflection of my message, I don't think I adequately described why it was a The client library of Auth0, under the hood, uses The hanging was caused by an issue between |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR demonstrates a regression test for #2200 and #1468 which has the same root cause. Since this test adds a dependency i would not recommend merging it but demonstrates how i was testing the problem.
As mentioned in my comment on the issue. The root cause was an old version of
gotand the old interceptors library having a clash. This has been fixed in newer versions.** see my comment below to why this is the case for Auth0
To verify I checked out the old version (v1.3.5) and built it. In the latest version I then removed the lib folder and used the lib folder from the old version in its place. I then removed all the other test files from the folder (to avoid dealing with broken references) and ran the following -
Hopefully this is enough to prove that #1468 can be closed and this pr can then just closed without merging.