Skip to content

Conversation

@ognevny
Copy link
Collaborator

@ognevny ognevny commented Dec 10, 2025

this time the release is stable. rquickjs patch is not needed, crate is already updated

@ognevny ognevny marked this pull request as draft December 10, 2025 05:54
@ognevny
Copy link
Collaborator Author

ognevny commented Dec 10, 2025

will push rebuilds later...

@ognevny ognevny marked this pull request as ready for review December 10, 2025 07:42
@ognevny
Copy link
Collaborator Author

ognevny commented Dec 10, 2025

need someone who help the emacs build 🙏

@mmuetzel
Copy link
Collaborator

mmuetzel commented Dec 10, 2025

need someone who help the emacs build 🙏

Try downloading the tarball from ftpmirror.gnu.org (instead of ftp.gnu.org).

Edit: Ah. That was only the reason why it failed for UCRT64. For CLANG64, it downloaded successfully but failed while building with errors like:

  In file included from ../../emacs-30.2/lib/fingerprint.c:20:
  In file included from ../src/config.h:3474:
  In file included from ../../emacs-30.2/src/conf_post.h:38:
  In file included from D:/_/B/src/build-CLANG64/../emacs-30.2/nt/inc/ms-w32.h:375:
  In file included from D:/M/msys64/clang64/include/direct.h:10:
  D:/M/msys64/clang64/include/io.h:354:17: error: conflicting types for '_lseek'
    354 |   off_t __cdecl lseek(int _FileHandle,off_t _Offset,int _Origin)
        |                 ^
  D:/_/B/src/build-CLANG64/../emacs-30.2/nt/inc/ms-w32.h:333:19: note: expanded from macro 'lseek'
    333 | #define lseek     _lseek
        |                   ^
  D:/M/msys64/clang64/include/io.h:212:24: note: previous declaration is here
    212 |   _CRTIMP long __cdecl _lseek(int _FileHandle,long _Offset,int _Origin);
        |                        ^

@ognevny
Copy link
Collaborator Author

ognevny commented Dec 10, 2025

need someone who help the emacs build 🙏

Try downloading the tarball from ftpmirror.gnu.org (instead of ftp.gnu.org).

there is a problem in source code too...

In file included from ../../emacs-30.2/lib/fingerprint.c:20:
  CC       boot-time.o
In file included from ../src/config.h:3474:
In file included from ../../emacs-30.2/src/conf_post.h:38:
In file included from D:/_/B/src/build-CLANG64/../emacs-30.2/nt/inc/ms-w32.h:375:
In file included from D:/M/msys64/clang64/include/direct.h:10:
D:/M/msys64/clang64/include/io.h:354:17: error: conflicting types for '_lseek'
  354 |   off_t __cdecl lseek(int _FileHandle,off_t _Offset,int _Origin)
      |                 ^
D:/_/B/src/build-CLANG64/../emacs-30.2/nt/inc/ms-w32.h:333:19: note: expanded from macro 'lseek'
  333 | #define lseek     _lseek
      |                   ^
D:/M/msys64/clang64/include/io.h:212:24: note: previous declaration is here
  212 |   _CRTIMP long __cdecl _lseek(int _FileHandle,long _Offset,int _Origin);
      |                        ^
In file included from ../../emacs-30.2/lib/acl_entries.c:20:
In file included from ../src/config.h:3474:
In file included from ../../emacs-30.2/src/conf_post.h:38:
In file included from D:/_/B/src/build-CLANG64/../emacs-30.2/nt/inc/ms-w32.h:375:
In file included from D:/M/msys64/clang64/include/direct.h:10:
D:/M/msys64/clang64/include/io.h:354:17: error: conflicting types for '_lseek'
  354 |   off_t __cdecl lseek(int _FileHandle,off_t _Offset,int _Origin)
      |                 ^
D:/_/B/src/build-CLANG64/../emacs-30.2/nt/inc/ms-w32.h:333:19: note: expanded from macro 'lseek'
  333 | #define lseek     _lseek
      |                   ^
D:/M/msys64/clang64/include/io.h:212:24: note: previous declaration is here
  212 |   _CRTIMP long __cdecl _lseek(int _FileHandle,long _Offset,int _Origin);
      |                        ^
1 error generated.
In file included from ../../emacs-30.2/lib/memmem.c:21:
In file included from ../src/config.h:3474:
In file included from ../../emacs-30.2/src/conf_post.h:38:
In file included from D:/_/B/src/build-CLANG64/../emacs-30.2/nt/inc/ms-w32.h:375:
In file included from D:/M/msys64/clang64/include/direct.h:10:
D:/M/msys64/clang64/include/io.h:354:17: error: conflicting types for '_lseek'
  354 |   off_t __cdecl lseek(int _FileHandle,off_t _Offset,int _Origin)
      |                 ^
D:/_/B/src/build-CLANG64/../emacs-30.2/nt/inc/ms-w32.h:333:19: note: expanded from macro 'lseek'
  333 | #define lseek     _lseek
      |                   ^
D:/M/msys64/clang64/include/io.h:212:24: note: previous declaration is here
  212 |   _CRTIMP long __cdecl _lseek(int _FileHandle,long _Offset,int _Origin);
      |                        ^
In file included from ../../emacs-30.2/lib/mktime.c:34:
In file included from ../../emacs-30.2/lib/libc-config.h:36:
In file included from ../src/config.h:3474:
In file included from ../../emacs-30.2/src/conf_post.h:38:
In file included from D:/_/B/src/build-CLANG64/../emacs-30.2/nt/inc/ms-w32.h:375:
In file included from D:/M/msys64/clang64/include/direct.h:10:
D:/M/msys64/clang64/include/io.h:354:17: error: conflicting types for '_lseek'
  354 |   off_t __cdecl lseek(int _FileHandle,off_t _Offset,int _Origin)
      |                 ^
D:/_/B/src/build-CLANG64/../emacs-30.2/nt/inc/ms-w32.h:333:19: note: expanded from macro 'lseek'
  333 | #define lseek     _lseek
      |                   ^
D:/M/msys64/clang64/include/io.h:212:24: note: previous declaration is here
  212 |   _CRTIMP long __cdecl _lseek(int _FileHandle,long _Offset,int _Origin);
      |                        ^
1 error generated.

@mmuetzel
Copy link
Collaborator

mmuetzel commented Dec 10, 2025

Yeah. Saw that too late.

Try adding -DNO_OLDNAMES to the CFLAGS. (I haven't tested that though.)

Edit: That won't work because of these declarations in stdio.h from mingw-w64 (there's no type called off_t with NO_OLDNAMES):

  int __cdecl fseeko(FILE *_File, off_t _Offset, int _Origin)
#if (defined(_FILE_OFFSET_BITS) && (_FILE_OFFSET_BITS == 64))
  __MINGW_ASM_CALL(fseeko64)
#endif
  ;
[...]
  off_t __cdecl ftello(FILE *_File)
#if (defined(_FILE_OFFSET_BITS) && (_FILE_OFFSET_BITS == 64))
  __MINGW_ASM_CALL(ftello64)
#endif
  ;

Is that a bug in that header?

@mmuetzel
Copy link
Collaborator

I opened #26811 with a potential fix for emacs.

this time the release is stable. rquickjs patch is not needed, crate is already updated
@ognevny ognevny merged commit d0216c6 into msys2:master Dec 10, 2025
8 checks passed
@ognevny ognevny deleted the update-tree-sitter branch December 10, 2025 18:37
@Master-Hash
Copy link
Contributor

Master-Hash commented Dec 11, 2025

#25667 seems occur again.

@Master-Hash
Copy link
Contributor

emacs-mirror/emacs@d587ce8

I suggest to backport this commit.

@ognevny
Copy link
Collaborator Author

ognevny commented Dec 11, 2025

thanks for pointing to a commit. will push now

@ognevny
Copy link
Collaborator Author

ognevny commented Dec 11, 2025

-> #26831

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants