Touchscreen fixes#74
Merged
SwissalpS merged 7 commits intomt-mods:masterfrom Oct 15, 2025
Merged
Conversation
modify_element_string might get a string that starts with an element unknown to formspec_elements.lua (p.ex. tableoptions)
…with a normal element
OgelGames
reviewed
Apr 9, 2025
OgelGames
reviewed
Apr 26, 2025
Co-authored-by: OgelGames <olliverdc28@gmail.com>
Contributor
|
tested the three cases, LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commit 1:
adding a table with color defined causes the string to start with
tableoptions=>formspec_elements[e] = nil=> crash on L26commit 2:
setting real_coordinates once caused them to always be true in the formspec, no matter of the actual value.
commit 3:
trying to modify an item_grid caused the whole grid to disappear, except for the last item.