Skip to content

Fix camera receptor bug#80

Closed
2424barrier wants to merge 1 commit intomt-mods:masterfrom
2424barrier:master
Closed

Fix camera receptor bug#80
2424barrier wants to merge 1 commit intomt-mods:masterfrom
2424barrier:master

Conversation

@2424barrier
Copy link
Copy Markdown

Modifies the position at which the receptor sends signals for the digiline camera as the change in a49e4dd broke many existing builds that relied on it.

@2424barrier 2424barrier marked this pull request as ready for review July 8, 2025 21:30
@SwissalpS
Copy link
Copy Markdown
Contributor

I had a hard time accepting the old way, it felt wrong. Of course changing this does break existing builds.

@OgelGames
Copy link
Copy Markdown
Contributor

OgelGames commented Jul 9, 2025

I agree with @SwissalpS, the offset was confusing, hence the change. Also, that change was made over 3 years ago, so changing it back will break new builds, likely more than fixing old ones.

@SwissalpS SwissalpS added the wontfix This will not be worked on label Jul 9, 2025
@2424barrier 2424barrier closed this Jul 9, 2025
@cheapie
Copy link
Copy Markdown
Contributor

cheapie commented Jul 12, 2025

The original reason for the offset was to allow for use of the camera as vehicle detection for traffic signals, like this:
screenshot_20250711_221233
However, upon thinking about this more, adding a single (0,-1,0) rule, in addition to the current ones, would also work just fine for this use. Does that sound acceptable? I can go come up with a PR (or have 2424barrier do one) if so.

@OgelGames
Copy link
Copy Markdown
Contributor

adding a single (0,-1,0) rule, in addition to the current ones

Sounds like a good solution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wontfix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants