(wip) Release utils [do not merge] #161
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For consistency with libcommon.pyx, where only u, v, vis are used
Some people (including me) are more confortable with more explicit names that make it apparent the conversion, instead of relying on memory to remember that all units are in radians, or cm.
Collaborator
|
what about this PR? Merge or close? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
galario.utilsthere are some general purpose functions that are useful. At the moment there is no way of calling them.Here, I add them to the installed payload and I make them importable as
or
This could be a framework to release future other Python-only functions.
It would allow, e.g., to distribute a Python version as a prototype of future CPU/GPU accelerated version.