525 data sets in configuration #529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsobel
requested review from
ottobolyos,
simonyg and
shaurabhsingh
and removed request for
ottobolyos
simonyg
approved these changes
Mar 7, 2025
ottobolyos
reviewed
Mar 7, 2025
There was a problem hiding this comment.
@wsobel, I don’t think I should be the one to review this PR, however, going though the changes I noticed a TODO comment which might or might not be already resolved.
| } | ||
| } | ||
|
|
||
| /// TODO: Add support for tables |
There was a problem hiding this comment.
The support of tables was added, wasn’t it? 🤔 If ao, either remove TODO: or the whole line.
|
Thanks for the comment. You name was auto populated for the review. Thanks for the review! Best |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support was added to parse data sets and tables in XML documents. This is to support the new configuration
CoordinateSystemsandMotion.