Add static isValid function to CronExpression #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to PHPUnit 6
Refactor timezones
if it can be null in the factory, the constructor should have it too also added phpdoc stuff
fix symmetry in constructor and factory method
Fixed infinite loop when resolving last weekday of the month from literals
[dependencies] Improve dependency declaration
…m-datetimeinterface Get timezone from DateTimeInterface
Add missing docblocks and normalize end of lines
highlight variables in `README`
PHP 8.2 deprecates `"${var}"` string interpolation pattern.
This fixes all three of such occurrences in `dragonmantank/cron-expression` package.
- [PHP 8.2: `${var}` string interpolation deprecated](https://php.watch/versions/8.2/${var}-string-interpolation-deprecated)
- [RFC](https://wiki.php.net/rfc/deprecate_dollar_brace_string_interpolation)
As discussed in mtdowling#133, the PHP 8.1's date extension daylight saving APIs have been suffering with instabilities. Let's skip the affected tests until php/php-src#9165 is resolved. Signed-off-by: Athos Ribeiro <[email protected]> Signed-off-by: Athos Ribeiro <[email protected]>
* mtdowling#137 Add check for multiple question marks * mtdowling#137 Validate position of question marks in expression
Added "throws" docblock section, so it's immediately obvious in which way an invalid cron expression will fail Co-authored-by: Roy Garrido <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my use of this repository, it would be very useful (is useful) to have a static function called isValid that simply returns TRUE or FALSE if the cronExpression is valid.