Skip to content

Proper imlementation for using access token in all use cases #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vetrivel-thanigaivel-23817 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Proper imlementation for using access token in all use cases #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4731a92
Proper imlementation for using access token
Jun 25, 2024
35912d8
Proper imlementation for using access token in all use cases
Jun 25, 2024
38b7bc4
Proper imlementation for using access token in all use cases
Jun 25, 2024
416ce27
Proper imlementation for using access token in all use cases
Jun 25, 2024
d541f7a
Proper imlementation for using access token in all use cases
Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 22 additions & 17 deletions js/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,15 +60,20 @@ const dataCollector = function dataCollector(response, username) {
};

const getData = function getData() {
console.log("started get data")
document.getElementById('searching').innerHTML = '<br/>Fetching projects...';
usersCurrentCall = 0;
callInProgress = true;
reqNo += 1;
const accessToken = localStorage.getItem('accessToken')
USERNAMES.forEach((username) => {
const url = `https://api.github.com/users/${username}/starred?per_page=${projectsPerPage}&access_token=${accessToken}&page=${reqNo}`;
const url = `https://api.github.com/users/${username}/starred?per_page=${projectsPerPage}&page=${reqNo}`;
axios({
url,
method: 'get',
headers : {
"Authorization" : `token ${accessToken}`
},
responseType: 'json',
}).then((response) => {
dataCollector(response, username);
Expand All @@ -92,23 +97,23 @@ if (window.localStorage) {
showCancelButton: true,
confirmButtonText: 'Submit',
showLoaderOnConfirm: false,
preConfirm(token) {
preConfirm: (token) => {
return new Promise((resolve, reject) => {
setTimeout(() => {
if (token === '') {
reject(new Error('Enter Valid Token'));
} else {
const url = `https://api.github.com/?access_token=${token}`;
axios({
url,
method: 'get',
responseType: 'json',
}).then(() => {
localStorage.setItem('accessToken', token);
resolve();
}).catch(() => reject(new Error('Error: invalid token')));
}
}, 1000);
if (token === '') {
reject('Enter Valid Token');
} else {
const url = 'https://api.github.com/';
axios.get(url, {
headers: {
'Authorization': `token ${token}`
}
})
.then(() => {
localStorage.setItem('accessToken', token);
resolve(token);
})
.catch(() => reject('Error: invalid token'));
}
});
},
allowOutsideClick: false,
Expand Down
5 changes: 4 additions & 1 deletion js/usernameSelection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,13 @@ const addUsername = function addUsername() {
} else {
// check for valid username
let accessToken = localStorage.getItem('accessToken');
const url = `https://api.github.com/users/${username}?access_token=${accessToken}`;
const url = `https://api.github.com/users/${username}`;
axios({
url,
method: 'get',
headers: {
'Authorization': `token ${accessToken}`
},
responseType: 'json',
}).then((response) => {
resolve();
Expand Down
26 changes: 26 additions & 0 deletions npm-debug.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
0 info it worked if it ends with ok
1 verbose cli [ '/home/vetri-zstch1321/.nvm/versions/node/v6.17.1/bin/node',
1 verbose cli '/home/vetri-zstch1321/.nvm/versions/node/v6.17.1/bin/npm',
1 verbose cli 'start' ]
2 info using npm@3.10.10
3 info using node@v6.17.1
4 verbose stack Error: missing script: start
4 verbose stack at run (/home/vetri-zstch1321/.nvm/versions/node/v6.17.1/lib/node_modules/npm/lib/run-script.js:151:19)
4 verbose stack at /home/vetri-zstch1321/.nvm/versions/node/v6.17.1/lib/node_modules/npm/lib/run-script.js:61:5
4 verbose stack at /home/vetri-zstch1321/.nvm/versions/node/v6.17.1/lib/node_modules/npm/node_modules/read-package-json/read-json.js:356:5
4 verbose stack at checkBinReferences_ (/home/vetri-zstch1321/.nvm/versions/node/v6.17.1/lib/node_modules/npm/node_modules/read-package-json/read-json.js:320:45)
4 verbose stack at final (/home/vetri-zstch1321/.nvm/versions/node/v6.17.1/lib/node_modules/npm/node_modules/read-package-json/read-json.js:354:3)
4 verbose stack at then (/home/vetri-zstch1321/.nvm/versions/node/v6.17.1/lib/node_modules/npm/node_modules/read-package-json/read-json.js:124:5)
4 verbose stack at /home/vetri-zstch1321/.nvm/versions/node/v6.17.1/lib/node_modules/npm/node_modules/read-package-json/read-json.js:311:12
4 verbose stack at /home/vetri-zstch1321/.nvm/versions/node/v6.17.1/lib/node_modules/npm/node_modules/graceful-fs/graceful-fs.js:78:16
4 verbose stack at tryToString (fs.js:457:3)
4 verbose stack at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:444:12)
5 verbose cwd /home/vetri-zstch1321/Documents/open-source/curiosity
6 error Linux 6.5.0-41-generic
7 error argv "/home/vetri-zstch1321/.nvm/versions/node/v6.17.1/bin/node" "/home/vetri-zstch1321/.nvm/versions/node/v6.17.1/bin/npm" "start"
8 error node v6.17.1
9 error npm v3.10.10
10 error missing script: start
11 error If you need help, you may report this error at:
11 error <https://github.com/npm/npm/issues>
12 verbose exit [ 1, true ]