Skip to content

Conversation

@asleszyn
Copy link

No description provided.

@asleszyn asleszyn requested a review from a team as a code owner March 12, 2021 14:22
@asleszyn asleszyn requested a review from lucckb March 12, 2021 14:23
return self.endpoint_request("developerMode", "put", body)

def get_application_stack(self):
body = {"applicationManager": True, "applicationStack": True }
Copy link
Contributor

@Kejzin Kejzin Mar 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't it be more readable if you put it in two separate lines? I Mean something like that:

body = {"applicationManager": True,
        "applicationSTack": True}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, will do.

Copy link
Contributor

@SP2FET SP2FET left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this already implemented in the OS part or it's in progress?
do you want to replace the keystroke application opening with this?

@asleszyn
Copy link
Author

@SP2FET there is a separate review for the OF part: mudita/MuditaOS#1770

Ideally, this would replace the key combos for app opening (more reliable IMO).

@SP2FET
Copy link
Contributor

SP2FET commented Mar 25, 2021

@SP2FET there is a separate review for the OF part: mudita/MuditaOS#1770

Ideally, this would replace the key combos for app opening (more reliable IMO).

yep, it should be more reliable but imho it should be discussed - harness had to simulate user's input :)

@asleszyn
Copy link
Author

Well, we can use both for different kinds of testing. Up to the test design I suppose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants