-
Notifications
You must be signed in to change notification settings - Fork 10
[CP-3907][App Refactor][Kompakt] Manage Files - upload #2730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for mudita-center-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop-next #2730 +/- ##
=================================================
- Coverage 68.75% 55.75% -13.00%
=================================================
Files 18 53 +35
Lines 464 1094 +630
Branches 77 208 +131
=================================================
+ Hits 319 610 +291
- Misses 139 463 +324
- Partials 6 21 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the file upload functionality for both Harmony and API devices, consolidating common file transfer logic into a shared model and implementing a unified transfer system with support for multiple transfer modes (Serial and MTP).
Key changes:
- Introduced a new common transfer model with
ExecuteTransferResult,FailedTransferItem, andTransferFilesActionType - Replaced device-specific upload implementations with a unified
transferFilesfunction supporting both Serial and MTP modes - Consolidated error handling and progress tracking across devices
Reviewed Changes
Copilot reviewed 54 out of 54 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
harmony-manage-files.screen.tsx |
Updated to use new transferFiles API with unified error handling |
use-harmony-os-update.mutation.ts |
Migrated from uploadFileToHarmony to new uploadFiles function |
upload-files.ts (Harmony) |
New implementation replacing old single-file upload with batch support |
transfer-files.ts (API Device) |
New orchestrator handling Serial/MTP mode switching and retry logic |
serial-upload-files-from-path.ts |
New Serial mode implementation with entity creation support |
manage-files-transfer-failed.copy.ts |
Updated error mapping to support action-type-specific error messages |
transfer-files.types.ts (common models) |
New shared types for transfer operations across devices |
map-to-categories.ts |
Fixed directory path construction to include storage path |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
libs/devices/api-device/routes/src/lib/screens/mc-file-manager/device-manage-files.screen.tsx
Outdated
Show resolved
Hide resolved
...ices/api-device/feature/src/lib/actions/serial-upload-files/serial-upload-files-from-path.ts
Outdated
Show resolved
Hide resolved
libs/devices/api-device/routes/src/lib/screens/mc-file-manager/device-manage-files.screen.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 62 out of 62 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JIRA Reference: CP-3907
📝 Description ️
💪 Checklist before requesting a review - nice to have
❗ Checklist before merging a pull request