Skip to content

Conversation

@dkarski
Copy link
Member

@dkarski dkarski commented Oct 28, 2025

JIRA Reference: CP-3907

📝 Description ️

💪 Checklist before requesting a review - nice to have

  • getState function in async thunk actions is correctly typed
  • redux selectors are used in components / prop drilling is reduce

❗ Checklist before merging a pull request

  • change went through the QA process
  • translations are updated in dedicated application
  • CHANGELOG.md is updated

@dkarski dkarski self-assigned this Oct 28, 2025
@netlify
Copy link

netlify bot commented Oct 28, 2025

Deploy Preview for mudita-center-storybook ready!

Name Link
🔨 Latest commit d3a417c
🔍 Latest deploy log https://app.netlify.com/projects/mudita-center-storybook/deploys/69203be7901dc9000890caf8
😎 Deploy Preview https://deploy-preview-2730--mudita-center-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

❌ Patch coverage is 49.15825% with 302 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.75%. Comparing base (12754a4) to head (d3a417c).

Files with missing lines Patch % Lines
...e/src/lib/actions/mtp-shared/mtp-transfer-files.ts 1.69% 58 Missing ⚠️
...rial-upload-files/serial-upload-files-from-path.ts 5.26% 54 Missing ⚠️
...rial-upload-files/serial-upload-files-from-data.ts 2.43% 40 Missing ⚠️
...ons/serial-download-files/serial-download-files.ts 2.50% 39 Missing ⚠️
...in/src/lib/node-mtp/utils/object-format.helpers.ts 52.94% 14 Missing and 2 partials ⚠️
...ons/mtp-upload-files/mtp-upload-files-from-path.ts 11.11% 16 Missing ⚠️
...src/lib/actions/mtp-shared/prepare-mtp-transfer.ts 7.14% 13 Missing ⚠️
...b/actions/mtp-download-files/mtp-download-files.ts 16.66% 10 Missing ⚠️
...actions/serial-upload-files/serial-upload-files.ts 30.00% 7 Missing ⚠️
...ture/src/lib/actions/transfer-files/mtp-watcher.ts 58.82% 6 Missing and 1 partial ⚠️
... and 13 more
Additional details and impacted files
@@                Coverage Diff                @@
##           develop-next    #2730       +/-   ##
=================================================
- Coverage         68.75%   55.75%   -13.00%     
=================================================
  Files                18       53       +35     
  Lines               464     1094      +630     
  Branches             77      208      +131     
=================================================
+ Hits                319      610      +291     
- Misses              139      463      +324     
- Partials              6       21       +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from CP-3908 to develop-next November 3, 2025 11:17
@dkarski dkarski temporarily deployed to development-next November 6, 2025 10:12 — with GitHub Actions Inactive
@dkarski dkarski temporarily deployed to development-next November 6, 2025 10:12 — with GitHub Actions Inactive
@dkarski dkarski temporarily deployed to development-next November 6, 2025 10:12 — with GitHub Actions Inactive
@dkarski dkarski temporarily deployed to development-next November 6, 2025 10:12 — with GitHub Actions Inactive
@dkarski dkarski temporarily deployed to development-next November 6, 2025 10:12 — with GitHub Actions Inactive
@dkarski dkarski temporarily deployed to development-next November 6, 2025 10:12 — with GitHub Actions Inactive
@dkarski dkarski temporarily deployed to development-next November 6, 2025 10:12 — with GitHub Actions Inactive
@dkarski dkarski temporarily deployed to development-next November 6, 2025 10:19 — with GitHub Actions Inactive
@dkarski dkarski temporarily deployed to development-next November 6, 2025 10:19 — with GitHub Actions Inactive
@dkarski dkarski temporarily deployed to development-next November 6, 2025 10:19 — with GitHub Actions Inactive
@dkarski dkarski temporarily deployed to development-next November 6, 2025 10:19 — with GitHub Actions Inactive
@dkarski dkarski temporarily deployed to development-next November 6, 2025 10:19 — with GitHub Actions Inactive
@dkarski dkarski temporarily deployed to development-next November 6, 2025 10:48 — with GitHub Actions Inactive
@dkarski dkarski temporarily deployed to development-next November 6, 2025 10:48 — with GitHub Actions Inactive
@dkarski dkarski temporarily deployed to development-next November 6, 2025 10:48 — with GitHub Actions Inactive
@dkarski dkarski temporarily deployed to development-next November 6, 2025 10:48 — with GitHub Actions Inactive
@dkarski dkarski temporarily deployed to development-next November 6, 2025 10:48 — with GitHub Actions Inactive
@dkarski dkarski temporarily deployed to development-next November 6, 2025 10:48 — with GitHub Actions Inactive
@dkarski dkarski temporarily deployed to development-next November 6, 2025 10:48 — with GitHub Actions Inactive
@dkarski dkarski requested a review from Copilot November 6, 2025 10:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the file upload functionality for both Harmony and API devices, consolidating common file transfer logic into a shared model and implementing a unified transfer system with support for multiple transfer modes (Serial and MTP).

Key changes:

  • Introduced a new common transfer model with ExecuteTransferResult, FailedTransferItem, and TransferFilesActionType
  • Replaced device-specific upload implementations with a unified transferFiles function supporting both Serial and MTP modes
  • Consolidated error handling and progress tracking across devices

Reviewed Changes

Copilot reviewed 54 out of 54 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
harmony-manage-files.screen.tsx Updated to use new transferFiles API with unified error handling
use-harmony-os-update.mutation.ts Migrated from uploadFileToHarmony to new uploadFiles function
upload-files.ts (Harmony) New implementation replacing old single-file upload with batch support
transfer-files.ts (API Device) New orchestrator handling Serial/MTP mode switching and retry logic
serial-upload-files-from-path.ts New Serial mode implementation with entity creation support
manage-files-transfer-failed.copy.ts Updated error mapping to support action-type-specific error messages
transfer-files.types.ts (common models) New shared types for transfer operations across devices
map-to-categories.ts Fixed directory path construction to include storage path

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dkarski dkarski temporarily deployed to development-next November 12, 2025 10:17 — with GitHub Actions Inactive
@dkarski dkarski temporarily deployed to development-next November 12, 2025 10:22 — with GitHub Actions Inactive
@dkarski dkarski temporarily deployed to development-next November 12, 2025 15:03 — with GitHub Actions Inactive
@dkarski dkarski temporarily deployed to development-next November 12, 2025 15:03 — with GitHub Actions Inactive
@dkarski dkarski marked this pull request as draft November 18, 2025 12:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 62 out of 62 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dkarski dkarski marked this pull request as ready for review November 20, 2025 12:12
@dkarski dkarski requested a review from mkurczewski November 20, 2025 12:12
@dkarski dkarski temporarily deployed to development-next November 21, 2025 10:16 — with GitHub Actions Inactive
@dkarski dkarski temporarily deployed to development-next November 21, 2025 10:16 — with GitHub Actions Inactive
@dkarski dkarski temporarily deployed to development-next November 21, 2025 10:16 — with GitHub Actions Inactive
@dkarski dkarski temporarily deployed to development-next November 21, 2025 10:16 — with GitHub Actions Inactive
@dkarski dkarski temporarily deployed to development-next November 21, 2025 11:44 — with GitHub Actions Inactive
@dkarski dkarski merged commit 7cf83a1 into develop-next Nov 21, 2025
12 of 17 checks passed
@dkarski dkarski deleted the CP-3907 branch November 21, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants