Skip to content

Conversation

@dkarski
Copy link
Member

@dkarski dkarski commented Nov 14, 2025

JIRA Reference: CP-3907

📝 Description ️

💪 Checklist before requesting a review - nice to have

  • getState function in async thunk actions is correctly typed
  • redux selectors are used in components / prop drilling is reduce

❗ Checklist before merging a pull request

  • change went through the QA process
  • translations are updated in dedicated application
  • CHANGELOG.md is updated

@dkarski dkarski self-assigned this Nov 14, 2025
@netlify
Copy link

netlify bot commented Nov 14, 2025

Deploy Preview for mudita-center-storybook ready!

Name Link
🔨 Latest commit df9f7b3
🔍 Latest deploy log https://app.netlify.com/projects/mudita-center-storybook/deploys/69203bce0bc1a40007ddf03d
😎 Deploy Preview https://deploy-preview-2744--mudita-center-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dkarski dkarski force-pushed the CP-3907-libs-generated branch from d66a368 to c54ec79 Compare November 18, 2025 12:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates MTP (Media Transfer Protocol) functionality from the legacy codebase into the app-mtp library, implementing file upload and export capabilities for Kompakt devices. The implementation provides cross-platform support through both Node.js (using WebUSB) and .NET approaches.

Key changes:

  • Implements MTP protocol handlers for device detection, storage management, and file transfers
  • Adds comprehensive utility functions for parsing MTP packets and data structures
  • Provides cross-platform support (Windows via .NET, Mac/Linux via Node.js WebUSB)

Reviewed Changes

Copilot reviewed 45 out of 47 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
package.json Added dev dependencies for body-parser, express, yargs and their type definitions
libs/app-mtp/main/tsconfig.lib.json Updated to include .d.ts declaration files
libs/app-mtp/main/src/lib/utils/* Error handling utilities for MTP operations
libs/app-mtp/main/src/lib/node-mtp/utils/* MTP protocol utilities (parsing, encoding, packet building)
libs/app-mtp/main/src/lib/node-mtp/* Node.js WebUSB MTP implementation
libs/app-mtp/main/src/lib/dotnet-mtp/* Windows .NET MTP implementation
libs/app-mtp/main/src/lib/app-mtp* Main MTP interface and factory
libs/app-mtp/main/src/lib/app-examples/* Example CLI and server implementations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dkarski dkarski marked this pull request as ready for review November 20, 2025 12:12
@dkarski dkarski requested a review from mkurczewski November 20, 2025 12:13
@dkarski dkarski temporarily deployed to development-next November 21, 2025 10:15 — with GitHub Actions Inactive
@dkarski dkarski temporarily deployed to development-next November 21, 2025 10:15 — with GitHub Actions Inactive
@dkarski dkarski temporarily deployed to development-next November 21, 2025 10:15 — with GitHub Actions Inactive
@dkarski dkarski temporarily deployed to development-next November 21, 2025 10:15 — with GitHub Actions Inactive
@dkarski dkarski temporarily deployed to development-next November 21, 2025 10:15 — with GitHub Actions Inactive
@dkarski dkarski temporarily deployed to development-next November 21, 2025 10:15 — with GitHub Actions Inactive
@dkarski dkarski temporarily deployed to development-next November 21, 2025 10:15 — with GitHub Actions Inactive
@dkarski dkarski merged commit 149fc39 into CP-3907-libs-generated Nov 21, 2025
7 checks passed
@dkarski dkarski deleted the CP-3907-app-mtp-moved branch November 21, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants