-
Notifications
You must be signed in to change notification settings - Fork 10
[CP-3907][App Refactor][Kompakt] Manage Files - upload - mtp - app-mtp moved from legacy (3) #2744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for mudita-center-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
d66a368 to
c54ec79
Compare
f3e2d69 to
f10c3b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates MTP (Media Transfer Protocol) functionality from the legacy codebase into the app-mtp library, implementing file upload and export capabilities for Kompakt devices. The implementation provides cross-platform support through both Node.js (using WebUSB) and .NET approaches.
Key changes:
- Implements MTP protocol handlers for device detection, storage management, and file transfers
- Adds comprehensive utility functions for parsing MTP packets and data structures
- Provides cross-platform support (Windows via .NET, Mac/Linux via Node.js WebUSB)
Reviewed Changes
Copilot reviewed 45 out of 47 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Added dev dependencies for body-parser, express, yargs and their type definitions |
| libs/app-mtp/main/tsconfig.lib.json | Updated to include .d.ts declaration files |
| libs/app-mtp/main/src/lib/utils/* | Error handling utilities for MTP operations |
| libs/app-mtp/main/src/lib/node-mtp/utils/* | MTP protocol utilities (parsing, encoding, packet building) |
| libs/app-mtp/main/src/lib/node-mtp/* | Node.js WebUSB MTP implementation |
| libs/app-mtp/main/src/lib/dotnet-mtp/* | Windows .NET MTP implementation |
| libs/app-mtp/main/src/lib/app-mtp* | Main MTP interface and factory |
| libs/app-mtp/main/src/lib/app-examples/* | Example CLI and server implementations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JIRA Reference: CP-3907
📝 Description ️
💪 Checklist before requesting a review - nice to have
❗ Checklist before merging a pull request