Skip to content

Conversation

@Aisuko
Copy link
Contributor

@Aisuko Aisuko commented Nov 5, 2023

Description

This PR fixes #915

Notes for Reviewers

Please kindly check the this page to get more detail of SAM. It is a demo for our SAM support plan.

  • The version of dependencies
  • The repo we are going to use to implement it
  • The result of showing masks in picture mode

Further request

I do not know how to debug(one-step-by-one-step), please show me any useful information to help me test it.

Signed commits

  • Yes, I signed my commits.

@Aisuko Aisuko changed the title Add sam support [WIP]: Add sam support Nov 5, 2023
@Aisuko Aisuko self-assigned this Nov 6, 2023
Signed-off-by: GitHub <[email protected]>
@Aisuko
Copy link
Contributor Author

Aisuko commented Nov 6, 2023

The CI issues are related to below

COPY extra/requirements.txt /build/extra/requirements.txt

I think it should be removed since we have been created separate env for every single extra backend. We do not need a requirements.txt

@Aisuko Aisuko changed the title [WIP]: Add sam support Add sam support Nov 6, 2023
@Aisuko Aisuko marked this pull request as ready for review November 7, 2023 00:00
@Aisuko Aisuko requested a review from mudler November 7, 2023 00:04
@mudler
Copy link
Owner

mudler commented Nov 9, 2023

The CI issues are related to below

COPY extra/requirements.txt /build/extra/requirements.txt

I think it should be removed since we have been created separate env for every single extra backend. We do not need a requirements.txt

yup correct. consider for SAM we might need an additional endpoint in the API - maybe we can look around other closed API services to mimic their API?

@Aisuko
Copy link
Contributor Author

Aisuko commented Nov 9, 2023

Hi @mudler, Do you mean the new API like?

app.Post("/v1/images/generations", auth, openai.ImageEndpoint(cl, options))

@Aisuko Aisuko changed the title Add sam support feat(sam): add sam support Nov 14, 2023
@Aisuko Aisuko closed this by deleting the head repository Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SAM support

2 participants