Open
Conversation
instead of opening everytime Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
jimmykarily
force-pushed
the
support-android-interfaces
branch
from
9a37799 to
a25d890
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1008 +/- ##
==========================================
- Coverage 34.32% 33.01% -1.31%
==========================================
Files 26 30 +4
Lines 2057 1805 -252
==========================================
- Hits 706 596 -110
+ Misses 1249 1107 -142
Partials 102 102 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The standard go-libp2p mDNS service calls net.Interfaces() internally, which triggers a bind() on netlink_route_socket — blocked by SELinux on Android. Replace the single Run() with two build-tag variants: - mdns_run.go (!android): original behaviour via mdns.NewMdnsService - mdns_android.go (android): uses anet.Interfaces() to bypass netlinkrib, calls zeroconf.RegisterProxy/Browse directly with explicit interfaces, and runs the peer-handling loop in a goroutine so Run() returns immediately (matching the non-Android contract — blocking here prevents startNetwork() from returning and starves the ledger and VPN service)
auto-merge was automatically disabled
April 16, 2026 18:39
Head branch was pushed to by a user without write access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support android interfaces by letting the caller pass it in instead of opening every time. Also allow the caller decide how to log (somewhere withing the android app interface)