Skip to content

Conversation

pmundt
Copy link

@pmundt pmundt commented Dec 13, 2019

This is an initial attempt at getting notifications from our backend into the system, which we plan to expand with additional events and actions over time.

Copy link
Collaborator

@CalmBit CalmBit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from the one small documentation point I pointed out. I don't know enough about this personally to approve it, but I can't see anything I'd reject!

@muesli
Copy link
Owner

muesli commented Dec 18, 2019

Looks good to me, too, apart from @rubiojr's comment. Let's try not to spam the console too much. In the meantime I'm working on a logger module that lets you browse/filter by each bee's individual output. That should improve the situation quite a bit.

@pmundt
Copy link
Author

pmundt commented Dec 18, 2019

I've now switched it over to the debug logger, as requested.

@muesli
Copy link
Owner

muesli commented Dec 21, 2019

One issue we got here is depending on http.NewRequestWithContext which is Go 1.13+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants