fix(output): report terminal status when writer is not a file #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymanbagabas
force-pushed
the
readwriter
branch
from
0f89b9f to
272baeb
Compare
aymanbagabas
force-pushed
the
readwriter
branch
from
272baeb to
f96dbec
Compare
aymanbagabas
force-pushed
the
readwriter
branch
from
f96dbec to
efeeaef
Compare
aymanbagabas
force-pushed
the
readwriter
branch
from
312c032 to
63dcd52
Compare
aymanbagabas
force-pushed
the
readwriter
branch
from
63dcd52 to
30e443b
Compare
The underlying writer doesn't have to be a *os.File for it to be a TTY. For example, a PTY ssh session is a TTY. However, the std library returns a io.ReadWriter for the ssh session. Combined with the WithUnsafe() option, we can query the terminal of an ssh session using Termenv.
aymanbagabas
force-pushed
the
ssh-pty
branch
from
434aa9a to
579fdf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying writer doesn't have to be a *os.File for it to be a TTY. For example, a PTY ssh session is a TTY. However, the std library returns a io.ReadWriter for the ssh session.
Combined with the WithUnsafe() option, we can query the terminal of an ssh session using Termenv.