[code-infra] Polish VS Code DX #1238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
requested review from
atomiks and
michaldudak
as code owners
oliviertassinari
added
scope: code-infra
Netlify deploy preview |
oliviertassinari
commented
Jan 3, 2025
Signed-off-by: Olivier Tassinari <[email protected]>
michaldudak
reviewed
Jan 6, 2025
.vscode/settings.json
Outdated
| "files.trimTrailingWhitespace": true, | ||
|
|
||
| // Root workspace only | ||
| "typescript.surveys.enabled": false, |
There was a problem hiding this comment.
Why do we want to enforce this?
.vscode/extensions.json
Outdated
| // Highlighting | ||
| "bradlc.vscode-tailwindcss", // Tailwind CSS | ||
| "unifiedjs.vscode-mdx", // MDX | ||
| "shardulm94.trailing-spaces", // Trailing spaces |
.vscode/launch.json
Outdated
michaldudak
reviewed
Jan 8, 2025
.vscode/extensions.json
Outdated
| "yoavbls.pretty-ts-errors", // TypeScript | ||
| "stylelint.vscode-stylelint", // Stylelint | ||
| "davidanson.vscode-markdownlint", // markdownlint | ||
| "chrischinchilla.vale-vscode" // Vale |
There was a problem hiding this comment.
I'm not entirely sure about Vale. It's useful for us, but the extension is not standalone (requires installing Vale separately), which could be worse DX for external contributors.
|
I removed the settings I found controversial and I'm about to merge this PR as it's been open for a long time. If you'd like to discuss the removed settings, we can do so in the next PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
michaldudak
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mui/material-ui#44865