[code-infra] Replace babel-plugin-add-import-extension #1899
+10
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janpot
added
improvement
commit: |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Janpot
commented
May 9, 2025
| @@ -20,7 +20,7 @@ | |||
| "docs:size-why": "cross-env DOCS_STATS_ENABLED=true pnpm docs:build", | |||
| "docs:start": "pnpm --filter docs serve", | |||
| "docs:link-check": "pnpm --filter docs link-check", | |||
| "extract-error-codes": "cross-env MUI_EXTRACT_ERROR_CODES=true lerna run --concurrency 8 build:modern", | |||
| "extract-error-codes": "cross-env MUI_EXTRACT_ERROR_CODES=true lerna run --concurrency 1 build:stable", | |||
There was a problem hiding this comment.
Not that it's important for this PR, but there is no modern build, and the command can never run concurrently as all build processes try to read and write the same file at the same time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed in https://github.com/mui/joy-ui/pull/116 that this plugin can't handle
.cssimports, it turns them into.css.js. Our plugin does resolve it correctly. base ui doesn't need to import css, but the plugin is quite outdated, we can align babel configs.