[field] Run validate function after native validations #1926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mj12albert
force-pushed
the
field/custom-validate-after-native
branch
from
f4a8e2c to
c875b2d
Compare
mj12albert
force-pushed
the
field/custom-validate-after-native
branch
from
c875b2d to
9d8f7b6
Compare
mj12albert
force-pushed
the
field/custom-validate-after-native
branch
from
9d8f7b6 to
d16170e
Compare
mj12albert
changed the title
mj12albert
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo: https://codesandbox.io/p/devbox/serene-brahmagupta-xgncdd
Currently a custom validation function will run before any native validations (e.g. required)
It makes more sense for the basic native checks to run before custom (presumably more complicated) checks, otherwise you'd have to recreate the native checks in the custom function
Closes #1904