-
-
Notifications
You must be signed in to change notification settings - Fork 122
[slider][field] Integrate range sliders with field #1929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mj12albert
wants to merge
5
commits into
mui:master
Choose a base branch
from
mj12albert:slider/range-slider-field
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
7e754fc
to
65c6ec7
Compare
mj12albert
commented
May 15, 2025
cecf7a6
to
c5f2040
Compare
264eb89
to
75227c6
Compare
75227c6
to
655e299
Compare
655e299
to
fbc72e5
Compare
I added multiple hidden inputs for the multi-select feature {multiple &&
Array.isArray(value) &&
value.map((v) => <input key={v} type="hidden" name={name} value={v} />)} const data = new FormData(event.currentTarget);
const submitted = data.getAll(name); // normal array |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1864
Preview: https://deploy-preview-1929--base-ui.netlify.app/experiments/slider/form
Added a
<input type="hidden">
in the root that is wired to Field and Form instead of the thumb's<input type="range">
One limitation is that if the range slider's value goes through
FormData
as part of form submission, it'll become a string ('[2,4]'
) and will need to be manuallyJSON.parse
-ed