Skip to content

[core] Performance: make browser-detect functions constants #1933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[core] Performance: make browser-detect functions constants #1933

wants to merge 3 commits into from

Conversation

romgrk
Copy link
Contributor

@romgrk romgrk commented May 16, 2025

Turn is(WebKit|IOS|Firefox) functions into constants.

@romgrk romgrk added core Infrastructure work going on behind the scenes improvement This is not a bug, nor a new feature performance labels May 16, 2025
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 16, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/@base-ui-components/react@1933

commit: c89cfcf

@netlify Netlify
Copy link

netlify bot commented May 16, 2025 •
edited
Loading

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit c89cfcf
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/6827a03c85bbf90008edfc83
😎 Deploy Preview https://deploy-preview-1933--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@romgrk romgrk changed the title [core] Performance: make browser detect functions constants [core] Performance: make browser-detect functions constants May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomiks atomiks Awaiting requested review from atomiks atomiks is a code owner

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

@michaldudak michaldudak Awaiting requested review from michaldudak michaldudak is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes improvement This is not a bug, nor a new feature performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@romgrk