Skip to content

[navigation menu] "Fix" Safari issue where positionerElement's width is set to 0 on hover #3309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+56 −8
Open

[navigation menu] "Fix" Safari issue where positionerElement's width is set to 0 on hover #3309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bc8de6f
adds a test for validating width
EmilNordling Nov 20, 2025
3817d5c
apply patch
EmilNordling Nov 23, 2025
00be922
reverses timing change. Applies an half hazardly fix
EmilNordling Nov 24, 2025
0ad4940
fixes the test scenario
EmilNordling Nov 24, 2025
ad68b69
fix Safari 18.1.1 navigation menu
EmilNordling Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions packages/react/src/navigation-menu/trigger/NavigationMenuTrigger.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,4 +110,50 @@ describe('<NavigationMenu.Trigger />', () => {
parseInt(getComputedStyle(positioner).getPropertyValue('--positioner-height'), 10),
).to.be.approximately(18, 1);
});

it.skipIf(isJSDOM)('handles positioner width correctly', async () => {
await render(
<NavigationMenu.Root>
<NavigationMenu.List>
<NavigationMenu.Item>
<NavigationMenu.Trigger>Overview</NavigationMenu.Trigger>
</NavigationMenu.Item>
<NavigationMenu.Item>
<NavigationMenu.Trigger>Handbook</NavigationMenu.Trigger>
<NavigationMenu.Content>
<NavigationMenu.Link href="#">Styling Base UI components</NavigationMenu.Link>
</NavigationMenu.Content>
</NavigationMenu.Item>
</NavigationMenu.List>
<NavigationMenu.Portal>
<NavigationMenu.Positioner data-testid="positioner">
<NavigationMenu.Popup>
<NavigationMenu.Viewport />
</NavigationMenu.Popup>
</NavigationMenu.Positioner>
</NavigationMenu.Portal>
</NavigationMenu.Root>,
);

const overviewButton = screen.getByRole('button', { name: 'Overview' });
const handbookButton = screen.getByRole('button', { name: 'Handbook' });

await userEvent.pointer([
{ target: overviewButton },
{ target: handbookButton, releasePrevious: true },
{ target: overviewButton, releasePrevious: true },
]);

await waitFor(() => {
const handbookLink = screen.getByRole('link', { name: 'Styling Base UI components' });

expect(handbookLink).toBeVisible();
});

const positioner = await screen.findByTestId('positioner');

expect(
parseInt(getComputedStyle(positioner).getPropertyValue('--positioner-width'), 10),
).to.be.approximately(183, 1);
});
});
18 changes: 10 additions & 8 deletions packages/react/src/navigation-menu/trigger/NavigationMenuTrigger.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,26 +129,28 @@ export const NavigationMenuTrigger = React.forwardRef(function NavigationMenuTri
positionerElement.style.removeProperty(NavigationMenuPositionerCssVars.positionerHeight);

const { width, height } = getCssDimensions(popupElement);
const measuredWidth = width || prevSizeRef.current.width;
const measuredHeight = height || prevSizeRef.current.height;

if (currentHeight === 0 || currentWidth === 0) {
currentWidth = width;
currentHeight = height;
currentWidth = measuredWidth;
currentHeight = measuredHeight;
}

popupElement.style.setProperty(NavigationMenuPopupCssVars.popupWidth, `${currentWidth}px`);
popupElement.style.setProperty(NavigationMenuPopupCssVars.popupHeight, `${currentHeight}px`);
positionerElement.style.setProperty(
NavigationMenuPositionerCssVars.positionerWidth,
`${width}px`,
`${measuredWidth}px`,
);
positionerElement.style.setProperty(
NavigationMenuPositionerCssVars.positionerHeight,
`${height}px`,
`${measuredHeight}px`,
);

sizeFrame1.request(() => {
popupElement.style.setProperty(NavigationMenuPopupCssVars.popupWidth, `${width}px`);
popupElement.style.setProperty(NavigationMenuPopupCssVars.popupHeight, `${height}px`);
popupElement.style.setProperty(NavigationMenuPopupCssVars.popupWidth, `${measuredWidth}px`);
popupElement.style.setProperty(NavigationMenuPopupCssVars.popupHeight, `${measuredHeight}px`);

sizeFrame2.request(() => {
animationAbortControllerRef.current = new AbortController();
Expand All @@ -158,13 +160,13 @@ export const NavigationMenuTrigger = React.forwardRef(function NavigationMenuTri
});

React.useEffect(() => {
if (!open) {
if (!mounted) {
stickIfOpenTimeout.clear();
sizeFrame1.cancel();
sizeFrame2.cancel();
prevSizeRef.current = DEFAULT_SIZE;
}
}, [stickIfOpenTimeout, open, sizeFrame1, sizeFrame2]);
}, [stickIfOpenTimeout, mounted, sizeFrame1, sizeFrame2]);

React.useEffect(() => {
if (!popupElement || typeof ResizeObserver !== 'function') {
Expand Down
Loading