Skip to content

[dialog][popover] Fix focus restoration when focused element is hidden with CSS #3313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[dialog][popover] Fix focus restoration when focused element is hidden with CSS #3313

wants to merge 2 commits into from
+53 −3

Conversation

@atomiks
Copy link
Contributor

@atomiks atomiks commented Nov 24, 2025 •
edited
Loading

Fixes #3299. While conditional rendering was handled via .isConnected, display: none (e.g. React.Activity) was not.

https://stackblitz.com/edit/eldph4db-edlqv6im

@atomiks atomiks added type: bug It doesn't behave as expected. component: dialog Changes related to the dialog component. component: popover Changes related to the popover component. labels Nov 24, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 24, 2025 •
edited
Loading

vite-css-base-ui-example

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/react@3313

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/utils@3313

commit: 36647bd

@mui-bot
Copy link

mui-bot commented Nov 24, 2025 •
edited
Loading

Bundle size report

Bundle Parsed size Gzip size
@base-ui-components/react 🔺+114B(+0.03%) 🔺+29B(+0.02%)

Details of bundle changes

Check out the code infra dashboard for more information about this PR.

@netlify
Copy link

netlify bot commented Nov 24, 2025 •
edited
Loading

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 36647bd
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/692402e28c09410008240d6b
😎 Deploy Preview https://deploy-preview-3313--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@atomiks atomiks marked this pull request as ready for review November 24, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

@michaldudak michaldudak Awaiting requested review from michaldudak michaldudak is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

component: dialog Changes related to the dialog component. component: popover Changes related to the popover component. type: bug It doesn't behave as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[popover] Popover loses focus when using Activity

2 participants

@atomiks @mui-bot