Skip to content

Conversation

@atomiks
Copy link
Contributor

@atomiks atomiks commented Nov 24, 2025

Fixes #3300

The id should always exist from the useBaseUiId util, so this throw doesn't need to happen following the switch to the effect instead of callback ref.

@atomiks atomiks added type: regression A bug, but worse, it used to behave as expected. scope: all components Widespread work has an impact on almost all components. labels Nov 24, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 24, 2025

vite-css-base-ui-example

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/react@3315
pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/utils@3315

commit: 94cce76

@atomiks atomiks force-pushed the fix/trigger-registration-17 branch from 7978de4 to 94cce76 Compare November 24, 2025 13:45
@netlify
Copy link

netlify bot commented Nov 24, 2025

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 7978de4
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/69246126f2c8de00082c1242
😎 Deploy Preview https://deploy-preview-3315--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mui-bot
Copy link

mui-bot commented Nov 24, 2025

Bundle size report

Bundle Parsed size Gzip size
@base-ui-components/react ▼-36B(-0.01%) ▼-15B(-0.01%)

Details of bundle changes


Check out the code infra dashboard for more information about this PR.

@netlify
Copy link

netlify bot commented Nov 24, 2025

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 94cce76
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/6924617bf7a13e0008728cfc
😎 Deploy Preview https://deploy-preview-3315--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: all components Widespread work has an impact on almost all components. type: regression A bug, but worse, it used to behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[popups] useTriggerRegistration throws error when react version < 18

2 participants