[otp field] Unmark preview#5029
Draft
atomiks wants to merge 1 commit into
Draft
Conversation
OTP Field is now stable and should be imported as `{ OTPField }` from
`@base-ui/react/otp-field` instead of `{ OTPFieldPreview }`.
- Rename the namespace export `OTPFieldPreview` -> `OTPField`
- Update tests, specs, demos, and type docs to the new export name
- Remove the preview note and switch the components list tag to `[New]`
- Document password manager autofill behavior (1Password requires an
input at least 80px wide for its inline popup to appear)
atomiks
added
breaking change
commit: |
Bundle size
PerformanceTotal duration: 1,214.30 ms -239.94 ms(-16.5%) | Renders: 50 (+0) | Paint: 1,824.57 ms -359.81 ms(-16.5%)
9 tests within noise — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Graduates OTP Field out of preview. It has been stable through several releases, all reported issues are resolved, and the API is settled.
Breaking change: the namespace export is renamed
OTPFieldPreview→OTPField. Consumers now import:Follows the Drawer de-preview precedent.
What changed
packages/react/src/otp-field/index.ts):export * as OTPFieldPreview→export * as OTPField.otp-field/page.mdx): removed the "in preview" note; fixed the anatomy import; added an "Autofill and password managers" section documenting that 1Password's inline autofill popup only appears for inputs ≥ 80px wide (manual fill from the extension works regardless), with themin-width: 80pxCSS workaround.components/page.mdx):OTP Field [Preview]→OTP Field [New].